From: cjb@laptop•org (Chris Ball)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM i.MX27: Add devicetree support
Date: Tue, 10 Apr 2012 10:12:36 -0400 [thread overview]
Message-ID: <87iph7wu97.fsf@laptop.org> (raw)
In-Reply-To: <20120410091715.GA3852@pengutronix.de> (Sascha Hauer's message of "Tue, 10 Apr 2012 11:17:15 +0200")
Hi,
On Tue, Apr 10 2012, Sascha Hauer wrote:
> On Sun, Apr 08, 2012 at 09:48:02PM -0400, Chris Ball wrote:
>> >
>> > [...]
>> > +static int __init imx27_avic_add_irq_domain(struct device_node *np,
>> > + struct device_node *interrupt_parent)
>> > +{
>> > + irq_domain_add_simple(np, 0);
>> > + return 0;
>> > +}
>> > +
>> > +static int __init imx27_gpio_add_irq_domain(struct device_node *np,
>> > + struct device_node *interrupt_parent)
>> > +{
>> > + static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS;
>> > +
>> > + irq_domain_add_simple(np, gpio_irq_base);
>> > +
>> > + return 0;
>> > +}
>>
>> This patch was merged for 3.4-rc1, but it fails to compile because Grant
>> removed irq_domain_add_simple() in 3.4-rc1.
>
> Thanks for noting. I assume that irq_domain_add_legacy is the right
> approach here, just like the other i.MX boards do, right?
Yeah, if you look at Grant's removal patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6b783f7c5dde2648fa0bbe7fc8ac80d78699e67f
.. he converted all of the in-tree uses to irq_domain_add_legacy()
at the time of removal, so that looks right.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop•org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-04-10 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 8:20 [PATCH] Add devicetree support for i.MX27 SoCs Sascha Hauer
2012-02-29 8:20 ` [PATCH 1/3] ARM i.MX27: Add devicetree support Sascha Hauer
2012-04-09 1:48 ` Chris Ball
2012-04-10 9:17 ` Sascha Hauer
2012-04-10 14:12 ` Chris Ball [this message]
2012-04-12 0:13 ` Fabio Estevam
2012-02-29 8:20 ` [PATCH 2/3] ARM i.MX: Add phytec phycore-i.MX27 (aka pcm038) " Sascha Hauer
2012-02-29 8:20 ` [PATCH 3/3] devicetree-bindings: Add documentation for i.MX generic boards Sascha Hauer
2012-03-01 7:00 ` [PATCH] Add devicetree support for i.MX27 SoCs Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iph7wu97.fsf@laptop.org \
--to=cjb@laptop$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox