public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/8] mmc: sdhci-pxav3: remove broken clock base quirk for Armada 38x sdhci driver
Date: Tue, 06 Oct 2015 16:43:48 +0200	[thread overview]
Message-ID: <87k2r09hwb.fsf@free-electrons.com> (raw)
In-Reply-To: <1444094562-31165-2-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Tue, 6 Oct 2015 03:22:35 +0200")

Hi Marcin,
 
 On mar., oct. 06 2015, Marcin Wojtas <mw@semihalf•com> wrote:

> From: Nadav Haklai <nadavh@marvell•com>
>
> shci-pxav3 driver is enabling by default the
> SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN quirk. However this quirk is not
> required for Armada 38x and leads to wrong clock setting in the divider.
>
> Signed-off-by: Nadav Haklai <nadavh@marvell•com>
> Signed-off-by: Marcin Wojtas <mw@semihalf•com>
> Cc: <stable@vger•kernel.org> # v4.2

Seems OK.

Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons•com>

Thanks,

Gregory

> ---
>  drivers/mmc/host/sdhci-pxav3.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 946d37f..976cddd 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -135,6 +135,7 @@ static int armada_38x_quirks(struct platform_device *pdev,
>  	struct sdhci_pxa *pxa = pltfm_host->priv;
>  	struct resource *res;
>  
> +	host->quirks &= ~SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN;
>  	host->quirks |= SDHCI_QUIRK_MISSING_CAPS;
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "conf-sdio3");
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2015-10-06 14:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06  1:22 [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas
2015-10-06  1:22 ` [PATCH 1/8] mmc: sdhci-pxav3: remove broken clock base quirk for Armada 38x sdhci driver Marcin Wojtas
2015-10-06 14:43   ` Gregory CLEMENT [this message]
2015-10-08 17:35   ` Ulf Hansson
2015-10-06  1:22 ` [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Marcin Wojtas
2015-10-06 14:44   ` Gregory CLEMENT
2015-10-08 17:35   ` Ulf Hansson
2015-10-06  1:22 ` [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas
2015-10-06 14:47   ` Gregory CLEMENT
2015-10-08 17:35   ` Ulf Hansson
2015-10-09  0:49     ` Marcin Wojtas
2015-10-06  1:22 ` [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas
2015-10-06 14:51   ` Gregory CLEMENT
2015-10-06 15:08     ` Marcin Wojtas
2015-10-09  1:09   ` Jisheng Zhang
2015-10-09  9:48     ` Marcin Wojtas
2015-10-06  1:22 ` [PATCH 5/8] mmc: sdhci-pxav3: enable usage of DAT3 pin as HW card detect Marcin Wojtas
2015-10-06  1:22 ` [PATCH 6/8] ARM: mvebu: enable SDHCI card detection using DAT3 pin on A388-GP Marcin Wojtas
2015-10-06  3:31   ` Andrew Lunn
2015-10-06  7:02     ` Marcin Wojtas
2015-10-06 14:45       ` Andrew Lunn
2015-10-06 15:05         ` Marcin Wojtas
2015-10-06 16:23           ` Andrew Lunn
2015-10-06 15:05       ` Gregory CLEMENT
2015-10-06 15:35         ` Marcin Wojtas
2015-10-06 16:20           ` Andrew Lunn
2015-10-06  1:22 ` [PATCH 7/8] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas
2015-10-06  1:22 ` [PATCH 8/8] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas
2015-10-06 14:43 ` [PATCH 0/8] Armada 38x SDHCI driver improvements Gregory CLEMENT
2015-10-06 15:48   ` Marcin Wojtas
2015-10-08 13:21     ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2r09hwb.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox