From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/6] Migrate PXA27x platforms to clock framework
Date: Sat, 26 Jul 2014 10:52:49 +0200 [thread overview]
Message-ID: <87k370o61q.fsf@free.fr> (raw)
In-Reply-To: <20140726004212.4791.52407@quantum> (Mike Turquette's message of "Fri, 25 Jul 2014 17:42:12 -0700")
Mike Turquette <mturquette@linaro•org> writes:
> Quoting Robert Jarzmik (2014-07-21 11:23:51)
>> Robert Jarzmik <robert.jarzmik@free•fr> writes:
>>
>> > This is the second opus of this serie.
>>
>> Ping ?
>
> Hi Robert,
>
> Overall the series looks good to me. The only problem I see is that
> somewhere in the use of the PARENTS() macro there is a section mismatch
> introduced. I spent about 5 minutes looking at it and gave up. This
> problem introduces 26 section mismatch warnings building
> colibri_pxa270_defconfig.
OK Mike, I'll fix this. This is probably because pxa27x_clocks array is not
__init, and it references parents which are __init. I was lazy letting
pxa27x_clocks not __init because I reuse the internal fields "hw" and "gate->hw"
later (hence I didn't leave the __init).
This is a bit dirty and I'll launder it.
Moreover, I have one fix which I had fixed wrt boot ordering : the
postcore_init() must die. The reason behind is that I have no guarantee of
ordering between clocks init and clocksource init, and clocksource relies on
clocks.
The right way will be AFAIK to call the core clocks init :
- within the device-tree initialization function : pxa27x_dt_clocks_init()
calls pxa27x_clocks_init9)
- directly from pxa27x_init() or pxa_timer_init() in non-device tree setup
> Once those are fixed up then I will be happy to take this series. Do you
> want me to take all six patches through the clk tree, including the
> arm/arm stuff?
I would feel more comfortable if :
- you take the 4 first ones (3 clock ones + 1 arm pxa header bit definitions)
- Haojian takes the last 2 ones (pxa ones)
I will check that taking only the first 4 ones doesn't break anything, in case
there is a merge window hipcup.
Cheers.
--
Robert
next prev parent reply other threads:[~2014-07-26 8:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 15:54 [PATCH v2 0/6] Migrate PXA27x platforms to clock framework Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 1/6] clk: add pxa clocks infrastructure Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 2/6] clk: dts: document pxa clock binding Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 3/6] arm: pxa: add clock pll selection bits Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 4/6] clk: add pxa27x clock drivers Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 5/6] dts: add devicetree bindings for pxa27x clocks Robert Jarzmik
2014-07-14 15:54 ` [PATCH v2 6/6] arm: pxa: Transition pxa27x to clk framework Robert Jarzmik
2014-12-26 9:56 ` Laurent Pinchart
2014-12-26 16:58 ` Robert Jarzmik
2014-07-21 18:23 ` [PATCH v2 0/6] Migrate PXA27x platforms to clock framework Robert Jarzmik
2014-07-26 0:42 ` Mike Turquette
2014-07-26 8:52 ` Robert Jarzmik [this message]
2014-07-28 23:55 ` Mike Turquette
2014-07-29 1:25 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k370o61q.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox