From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler
Date: Mon, 12 Mar 2012 11:52:41 -0700 [thread overview]
Message-ID: <87k42py7ly.fsf@ti.com> (raw)
In-Reply-To: <1331118963-26364-6-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 7 Mar 2012 16:45:55 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti•com> writes:
> This local variable is just assigned zero and then OR'ed
> with isr. It does not appear to serve any purpose and so
> removing it.
Still missing the changelog changes I requested in v1.
Kevin
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti•com>
> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
> Acked-by: Felipe Balbi <balbi@ti•com>
> ---
> drivers/gpio/gpio-omap.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 3765654..de5fe8f 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -626,7 +626,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
> u32 isr;
> unsigned int gpio_irq, gpio_index;
> struct gpio_bank *bank;
> - u32 retrigger = 0;
> int unmasked = 0;
> struct irq_chip *chip = irq_desc_get_chip(desc);
>
> @@ -663,8 +662,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
> chained_irq_exit(chip, desc);
> }
>
> - isr |= retrigger;
> - retrigger = 0;
> if (!isr)
> break;
next prev parent reply other threads:[~2012-03-12 18:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 11:15 [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 01/13] gpio/omap: remove saved_fallingdetect, saved_risingdetect fields Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 02/13] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup() Tarun Kanti DebBarma
2012-03-07 11:59 ` Santosh Shilimkar
2012-03-07 11:15 ` [PATCH v3 03/13] gpio/omap: remove suspend_wakeup field from struct gpio_bank Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 04/13] gpio/omap: remove saved_wakeup " Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler Tarun Kanti DebBarma
2012-03-09 8:46 ` DebBarma, Tarun Kanti
2012-03-12 18:53 ` Kevin Hilman
2012-03-12 18:52 ` Kevin Hilman [this message]
2012-03-07 11:15 ` [PATCH v3 06/13] gpio/omap: fix trigger type to unsigned Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 07/13] gpio/omap: fix _set_gpio_irqenable implementation Tarun Kanti DebBarma
2012-03-07 11:15 ` [PATCH v3 08/13] gpio/omap: remove redundant decoding of gpio offset Tarun Kanti DebBarma
2012-03-07 12:00 ` Santosh Shilimkar
2012-03-07 11:15 ` [PATCH v3 09/13] gpio/omap: remove suspend/resume callbacks Tarun Kanti DebBarma
2012-03-07 12:01 ` Santosh Shilimkar
2012-03-07 11:16 ` [PATCH v3 10/13] gpio/omap: fix missing dataout context save in _set_gpio_dataout_reg Tarun Kanti DebBarma
2012-03-07 12:03 ` Santosh Shilimkar
2012-03-08 3:34 ` DebBarma, Tarun Kanti
2012-03-07 11:16 ` [PATCH v3 11/13] gpio/omap: fix dataout register overwrite in _set_gpio_dataout_* Tarun Kanti DebBarma
2012-03-07 12:04 ` Santosh Shilimkar
2012-03-12 21:54 ` Kevin Hilman
2012-03-13 6:03 ` DebBarma, Tarun Kanti
2012-03-13 6:33 ` DebBarma, Tarun Kanti
2012-03-13 6:52 ` DebBarma, Tarun Kanti
2012-03-13 16:27 ` Kevin Hilman
2012-03-14 1:53 ` DebBarma, Tarun Kanti
2012-03-07 11:16 ` [PATCH v3 12/13] gpio/omap: fix incorrect context restore logic in omap_gpio_runtime_resume Tarun Kanti DebBarma
2012-03-07 12:07 ` Santosh Shilimkar
2012-03-08 3:58 ` DebBarma, Tarun Kanti
2012-03-08 7:19 ` Shilimkar, Santosh
2012-03-09 9:25 ` DebBarma, Tarun Kanti
2012-03-07 11:16 ` [PATCH v3 13/13] gpio/omap: fix incorrect update to context.irqenable1 Tarun Kanti DebBarma
2012-03-07 12:09 ` Santosh Shilimkar
2012-03-12 22:09 ` Kevin Hilman
2012-03-13 5:31 ` DebBarma, Tarun Kanti
2012-03-12 18:54 ` [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes Kevin Hilman
2012-03-12 19:53 ` DebBarma, Tarun Kanti
2012-03-12 20:08 ` DebBarma, Tarun Kanti
2012-03-12 20:27 ` DebBarma, Tarun Kanti
2012-03-12 22:17 ` Kevin Hilman
2012-03-12 22:28 ` Kevin Hilman
2012-03-13 3:57 ` Grant Likely
2012-03-13 4:35 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k42py7ly.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox