From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding
Date: Mon, 19 Jan 2015 20:29:40 +0100 [thread overview]
Message-ID: <87lhkyh8m3.fsf@free.fr> (raw)
In-Reply-To: <20150119083533.GF21886@x1> (Lee Jones's message of "Mon, 19 Jan 2015 08:35:33 +0000")
Lee Jones <lee.jones@linaro•org> writes:
> On Fri, 16 Jan 2015, Robert Jarzmik wrote:
>
>> Add a binding for lubbock motherboard IO board.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free•fr>
>> ---
>> .../devicetree/bindings/mfd/lubbock-io.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/lubbock-io.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/lubbock-io.txt b/Documentation/devicetree/bindings/mfd/lubbock-io.txt
>> new file mode 100644
>> index 0000000..33c9e21
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/lubbock-io.txt
>> @@ -0,0 +1,26 @@
>> +Intel's pxa255 system development platform motherboard.
>
> s/pxa25/PXA25/
Ok.
>
> "system development platform motherboard" doesn't quite sit right with me.
>
> How about "Intel Xscale PXA255 development platform (Lubbock)"?
OK.
>
>> +This is the motherboard, or IO board, of the pxa25x development system,
>> +supporting a lubbock pxa25x SoC board.
>
> Again, this sounds weird.
Would it sound better with :
This regroups all the CPLDs on the Lubbock motherboard, providing interrupt
muxing, leds handling, ...
>
>> +Required properties:
>> + - compatible : One of the following chip-specific strings:
>> + "intel,lubbock-io"
>
> An odd thing to say with only one entry.
Right, a simple "should be" would fit better.
>
>> + - interrupts : The first interrupt is the line the /IRQ signal the IO board
>> + multiplex is connected to. The only known case is GPIO0 on the
>> + pxa25x SoC.
>
> Can you get someone to help you re-word this into a more fluid
> sentence?
Aouch, how about this :
interrupts : The first interrupt is the SoC input interrupt connected to the
lubbock IO board interrupt multiplexer output. The only known
working configuration is GPIO0 on the pxa25x SoC.
>
>> +Optional properties:
>> + - interrupts : The second optional interrupt is the base of the interrupts
>> + multiplexed by the lubbock motherboard. If unspecified, the
>> + range is fully dynamic, and the irqdomain will generate its
>> + interrupt base on the fly.
>> +
>> +Example:
>> +
>> +mb: lubbock-mb at 0 {
>> + compatible = "intel,lubbock-io";
>> + interrupts = <0 IRQ_TYPE_EDGE_FALLING 400 IRQ_TYPE_NONE>;
>> + #interrupt-cells = <2>;
>> + interrupt-parent = <&pxairq>;
>
> Whitespace error.
Right.
> I'm guessing mb means motherboard? I think it's unusual for a
> motherboard to have it's own driver. Usually we provide drivers for
> the individual components/peripherals situated on the board.
Yes, mb for motherboard. Well, this driver is actually for the CPLDs on the
motherboard. Would "lubbock-cplds" be a better choice ?
Cheers.
--
Robert
next prev parent reply other threads:[~2015-01-19 19:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 11:00 [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding Robert Jarzmik
2015-01-16 11:00 ` [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board Robert Jarzmik
2015-01-19 9:17 ` Lee Jones
2015-01-19 19:09 ` Robert Jarzmik
2015-01-20 10:29 ` Lee Jones
2015-01-20 11:56 ` Russell King - ARM Linux
2015-01-21 7:46 ` Robert Jarzmik
2015-01-21 8:16 ` Lee Jones
2015-01-21 8:27 ` Robert Jarzmik
2015-01-21 12:35 ` Lee Jones
2015-01-21 13:02 ` Russell King - ARM Linux
2015-01-21 13:36 ` robert.jarzmik at free.fr
2015-01-21 15:10 ` Lee Jones
2015-01-21 19:22 ` Robert Jarzmik
2015-01-21 9:47 ` Russell King - ARM Linux
2015-01-21 9:44 ` Russell King - ARM Linux
2015-01-21 16:05 ` unclear ipv6 redirect message (was Re: [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board) Joe Perches
2015-01-21 16:11 ` Russell King - ARM Linux
2015-01-21 16:40 ` Joe Perches
2015-01-21 16:46 ` Russell King - ARM Linux
2015-01-16 11:00 ` [PATCH v3 3/3] ARM: pxa: lubbock: use new lubbock_io driver Robert Jarzmik
2015-01-19 8:35 ` [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding Lee Jones
2015-01-19 19:29 ` Robert Jarzmik [this message]
2015-01-20 10:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhkyh8m3.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox