From: rusty@rustcorp•com.au (Rusty Russell)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] virtio: Add platform bus driver for memory mapped virtio device
Date: Tue, 18 Oct 2011 14:39:17 +1030 [thread overview]
Message-ID: <87lisjq6tu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1317921230.28696.102.camel@hornet.cambridge.arm.com>
On Thu, 06 Oct 2011 18:13:50 +0100, Pawel Moll <pawel.moll@arm•com> wrote:
> > I'll post the updated device spec shortly.
>
> Here it goes. I'm actually happy about the "maximum queue size" solution
> - it worked out quite neat in the end :-)
>
> Please, do have a look at the hopefully final shape of things and
> comment if you still see some potential issues :-)
>
> Cheers!
>
> Pawel
Looks good. I'll have a go at moving it across to the LyX master soon.
> \item 0x028 | W | GuestPageSize \\
> Guest page size.\\
> Device driver must write the guest page size in bytes to the register
> during initialization, before any queues are used.
This has to be a power of 2, and you should specify what it's used for.
It's really the multiplier for PFN values, right?
> \item 0x03c | W | QueueAlign \\
> Used Ring alignment in the virtual queue.\\
> Writing to this register notifies the Host about alignment boundary of
> the Used Ring in bytes. This applies to the queue selected by writing to
> QueueSel.
Either specify that this must be a power of 2, or actually specify it as
the power of 2 to use, (ie. valid values are 1 through 16, with 12 being
the value that virtio PCI would use).
Otherwise you have to do a divide on the qemu side.
Looks good otherwise though!
Cheers,
Rusty.
next prev parent reply other threads:[~2011-10-18 4:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 13:47 [PATCH] virtio: Add platform bus driver for memory mapped virtio device Pawel Moll
2011-09-28 13:54 ` Pawel Moll
2011-10-03 23:46 ` Rusty Russell
2011-10-04 16:16 ` Pawel Moll
2011-10-05 1:10 ` Rusty Russell
2011-10-05 10:06 ` Pawel Moll
2011-10-05 18:57 ` [PATCH v2] " Pawel Moll
2011-10-06 16:50 ` [PATCH v3] " Pawel Moll
2011-10-06 17:13 ` Pawel Moll
2011-10-18 4:09 ` Rusty Russell [this message]
2011-10-18 9:44 ` Pawel Moll
2011-10-19 2:57 ` Rusty Russell
2011-10-21 17:57 ` Pawel Moll
2011-10-24 2:33 ` Rusty Russell
2011-10-24 13:06 ` Pawel Moll
2011-10-24 13:07 ` [PATCH v4] " Pawel Moll
2011-10-25 1:13 ` Rusty Russell
2011-10-26 4:06 ` [PATCH v3] " Rusty Russell
2011-10-26 9:54 ` Pawel Moll
2011-10-26 11:50 ` Rusty Russell
2011-10-13 16:49 ` Pawel Moll
2011-10-05 10:39 ` [PATCH] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lisjq6tu.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox