From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Voipac PXA270: UDC and UHC support
Date: Mon, 15 Mar 2010 20:21:37 +0100 [thread overview]
Message-ID: <87ljdtpf0e.fsf@free.fr> (raw)
In-Reply-To: <201003132300.55480.marek.vasut@gmail.com> (Marek Vasut's message of "Sat, 13 Mar 2010 23:00:55 +0100")
Marek Vasut <marek.vasut@gmail•com> writes:
> Dne P? 12. b?ezna 2010 18:49:54 Robert Jarzmik napsal(a):
>> Marek Vasut <marek.vasut@gmail•com> writes:
>> > Dne St 10. b?ezna 2010 05:43:00 Marek Vasut napsal(a):
>> >> Hi,
>> >> this patch adds UDC and UHC support (and formating fix, I hope you dont
>> >> mind Eric).
>> >>
>> >> Signed-off-by: Marek Vasut <marek.vasut@gmail•com>
>> >
>> > revised patch
Yes, I feel that one much better.
One minor comments remain for me.
> +/******************************************************************************
> + * USB Gadget
> + ******************************************************************************/
> +#if defined(CONFIG_USB_GADGET_PXA27X)||defined(CONFIG_USB_GADGET_PXA27X_MODULE)
> +static struct gpio_vbus_mach_info vpac270_gpio_vbus_info = {
> + .gpio_vbus = GPIO41_VPAC270_UDC_DETECT,
> + .gpio_pullup = -1,
> +};
> +
> +static struct platform_device vpac270_gpio_vbus = {
> + .name = "gpio-vbus",
> + .id = -1,
> + .dev = {
> + .platform_data = &vpac270_gpio_vbus_info,
> + },
> +};
> +
> +static void vpac270_udc_command(int cmd)
> +{
> + if (cmd == PXA2XX_UDC_CMD_CONNECT)
> + UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE;
> + else if (cmd == PXA2XX_UDC_CMD_DISCONNECT)
> + UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE);
In the "DISCONNECT" case, you reset UP2OCR_HXOE, meaning the usb port isn't a
USB Device anymore (neither a USB host). If that's on purpose, then all good, in
the other case, don't reset that one.
Otherwise, you can add for the UDC part :
Reviewed-by: Robert Jarzmik <robert.jarzmik@free•fr>
--
Robert
next prev parent reply other threads:[~2010-03-15 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 4:43 [PATCH] Voipac PXA270: UDC and UHC support Marek Vasut
2010-03-10 11:43 ` Marek Vasut
2010-03-12 17:49 ` Robert Jarzmik
2010-03-12 21:42 ` Marek Vasut
2010-03-13 22:00 ` Marek Vasut
2010-03-15 19:21 ` Robert Jarzmik [this message]
2010-03-22 1:57 ` Eric Miao
2010-03-22 3:28 ` Marek Vasut
2010-03-22 4:04 ` Eric Miao
2010-03-22 13:06 ` Marek Vasut
2010-03-22 13:56 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljdtpf0e.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox