public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init
Date: Thu, 10 May 2012 07:23:56 -0700	[thread overview]
Message-ID: <87mx5gm7wj.fsf@ti.com> (raw)
In-Reply-To: <CAC83ZvKHDWmNneK5GQgSPhdg88apymEgUr0zm1EVYjfaWG2oXA@mail.gmail.com> (Tarun Kanti DebBarma's message of "Thu, 10 May 2012 10:45:13 +0530")

Grant,

"DebBarma, Tarun Kanti" <tarun.kanti@ti•com> writes:

> Hi,
>
> On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik
> <jkrzyszt@tis•icnet.pl> wrote:
>> On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote:
>>> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas <notasas@gmail•com> wrote:
>>> > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma
>>> > <tarun.kanti@ti•com> wrote:
>>> >> Initialization of irqenable, irqstatus registers is the common
>>> >> operation done in this function for all OMAP platforms, viz. OMAP1,
>>> >> OMAP2+. The latter _gpio_rmw()'s which supposedly got introduced
>>> >> wrongly to take care of OMAP2+ platforms were overwriting initially
>>> >> programmed OMAP1 value breaking functionality on OMAP1.
>>
>> Hi,
>> I can confirm that my other issues with GPIO on Amstrad Delta were not
>> related, and this patch is still required for GPIO interrupts hardware
>> being correctly initialized on OMAP1 in 3.4-rc6. You can add my
>>
>> Tested-by: Janusz Krzysztofik <jkrzyszt@tis•icnet.pl>
>>
>> if you wish.
> Thank you for confirming!!

We'd like to get this one in for v3.4-rc.  Can you queue it?

I added the tested-by from Janusz and my signoff, and pull request is
below.

Thanks,

Kevin



The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3:

  Linux 3.4-rc6 (2012-05-06 15:07:32 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/fixes/gpio

for you to fetch changes up to 6edd94db250038c8fdf176f23ca4017d2f312509:

  gpio/omap: fix incorrect initialization of omap_gpio_mod_init (2012-05-10 07:16:15 -0700)

----------------------------------------------------------------
Tarun Kanti DebBarma (1):
      gpio/omap: fix incorrect initialization of omap_gpio_mod_init

 drivers/gpio/gpio-omap.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

  reply	other threads:[~2012-05-10 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30  7:20 [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init Tarun Kanti DebBarma
2012-05-05 21:55 ` Grazvydas Ignotas
2012-05-07  5:22   ` DebBarma, Tarun Kanti
2012-05-09 21:36     ` Janusz Krzysztofik
2012-05-10  5:15       ` DebBarma, Tarun Kanti
2012-05-10 14:23         ` Kevin Hilman [this message]
2012-05-11 18:57           ` Grant Likely
2012-05-11 18:58     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx5gm7wj.fsf@ti.com \
    --to=khilman@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox