public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: jacmet@sunsite•dk (Peter Korsgaard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes
Date: Mon, 09 Jan 2012 13:20:13 +0100	[thread overview]
Message-ID: <87mx9xdq4i.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120109121322.GM21765@n2100.arm.linux.org.uk> (Russell King's message of "Mon, 9 Jan 2012 12:13:22 +0000")

>>>>> "Russell" == Russell King <- ARM Linux <linux@arm•linux.org.uk>> writes:

Hi,

 Russell> You describe the RGB555 vs RGB565 via the bitfield values in
 Russell> var->red, var-> green and var->blue.  So, RGB(or BGR)565 has
 Russell> var->green.length with 6, and RGB(or BGR)555 has this as 5.
 Russell> In both cases, bits_per_pixel is 16 as that's the width of a
 Russell> pixel in the frame buffer.

 Russell> If the bitfield can't be interpreted by the driver as
 Russell> identifying one of these combinations, then you're supposed to
 Russell> chose one (and in the case where it's fixed by hardware, you
 Russell> set the bitfields according to what the hardware supports.)

Indeed, and as the hardware can only interprete 1/2/4/8 paletted and
16/24 RGB, we shouldn't claim to support 15bit.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-01-09 12:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 14:52 [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Peter Korsgaard
2012-01-05 11:26 ` Peter Korsgaard
2012-01-09  2:49   ` Florian Tobias Schandinat
2012-01-09  6:15     ` Peter Korsgaard
2012-01-09 13:36     ` Nicolas Ferre
2012-01-09 10:34 ` Nicolas Ferre
2012-01-09 11:13   ` Peter Korsgaard
2012-01-09 13:32     ` Nicolas Ferre
2012-01-10 13:01     ` Christian Glindkamp
2012-01-10 13:17       ` Peter Korsgaard
2012-01-10 16:42       ` Peter Korsgaard
2012-01-10 14:02     ` Jamie Lokier
2012-01-10 14:19       ` Peter Korsgaard
2012-01-10 21:06       ` Russell King - ARM Linux
2012-01-09 12:13   ` Russell King - ARM Linux
2012-01-09 12:20     ` Peter Korsgaard [this message]
2012-01-30  5:12 ` Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx9xdq4i.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite$(echo .)dk \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox