From: gregory.clement@bootlin•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/11] cpufreq: mvebu: Remove OPPs using dev_pm_opp_remove()
Date: Wed, 19 Sep 2018 17:20:16 +0200 [thread overview]
Message-ID: <87o9ctjyz3.fsf@bootlin.com> (raw)
In-Reply-To: <b6e58baec5ee4cf56f82c4b14dad7320cf01ce7f.1536736872.git.viresh.kumar@linaro.org> (Viresh Kumar's message of "Wed, 12 Sep 2018 13:58:46 +0530")
Hi Viresh,
On mer., sept. 12 2018, Viresh Kumar <viresh.kumar@linaro•org> wrote:
> dev_pm_opp_cpumask_remove_table() is going to change in the next commit
> and will not remove dynamic OPPs automatically. They must be removed
> with a call to dev_pm_opp_remove().
So now that mean when adding more than 2 OPPs, we should have the list
of them available in the driver to be able to remove them, right?
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro•org>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin•com>
Gregory
> ---
> drivers/cpufreq/mvebu-cpufreq.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/cpufreq/mvebu-cpufreq.c b/drivers/cpufreq/mvebu-cpufreq.c
> index 31513bd42705..6d33a639f902 100644
> --- a/drivers/cpufreq/mvebu-cpufreq.c
> +++ b/drivers/cpufreq/mvebu-cpufreq.c
> @@ -84,9 +84,10 @@ static int __init armada_xp_pmsu_cpufreq_init(void)
>
> ret = dev_pm_opp_add(cpu_dev, clk_get_rate(clk) / 2, 0);
> if (ret) {
> + dev_pm_opp_remove(cpu_dev, clk_get_rate(clk));
> clk_put(clk);
> dev_err(cpu_dev, "Failed to register OPPs\n");
> - goto opp_register_failed;
> + return ret;
> }
>
> ret = dev_pm_opp_set_sharing_cpus(cpu_dev,
> @@ -99,11 +100,5 @@ static int __init armada_xp_pmsu_cpufreq_init(void)
>
> platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
> return 0;
> -
> -opp_register_failed:
> - /* As registering has failed remove all the opp for all cpus */
> - dev_pm_opp_cpumask_remove_table(cpu_possible_mask);
> -
> - return ret;
> }
> device_initcall(armada_xp_pmsu_cpufreq_init);
> --
> 2.18.0.rc1.242.g61856ae69a2c
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-09-19 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 8:28 [PATCH 00/11] OPP: Don't create multiple OPP tables for devices sharing OPP table Viresh Kumar
2018-09-12 8:28 ` [PATCH 07/11] cpufreq: mvebu: Remove OPPs using dev_pm_opp_remove() Viresh Kumar
2018-09-19 15:20 ` Gregory CLEMENT [this message]
2018-09-19 21:40 ` Viresh Kumar
2018-09-12 13:55 ` [PATCH 00/11] OPP: Don't create multiple OPP tables for devices sharing OPP table Niklas Cassel
2018-09-13 7:48 ` Viresh Kumar
2018-09-13 10:21 ` Niklas Cassel
2018-09-19 21:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9ctjyz3.fsf@bootlin.com \
--to=gregory.clement@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox