From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [GIT PULL] cpufreq: OMAP updates for v3.4
Date: Thu, 15 Mar 2012 07:25:43 -0700 [thread overview]
Message-ID: <87obryc55k.fsf@ti.com> (raw)
In-Reply-To: <CANOLnON+hHtnjo9samAqvXp_nVJMjQ7CnxMCe7ggO4UwYaz4rw@mail.gmail.com> (Grazvydas Ignotas's message of "Wed, 14 Mar 2012 19:38:38 +0200")
Grazvydas Ignotas <notasas@gmail•com> writes:
> On Wed, Mar 14, 2012 at 7:22 PM, Kevin Hilman <khilman@ti•com> wrote:
>> Grazvydas Ignotas <notasas@gmail•com> writes:
>>
>> [...]
>>
>>>> Russell King (1):
>>>> ? ? ?cpufreq: OMAP driver depends CPUfreq tables
>>>
>>> It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
>>> instead of depends.
>>
>> That was intentional. ?What do you think is messed up about it?
>>
>> It's the same as saying:
>>
>> ? ? depends on ARCH_OMAP2PLUS
>> ? ? default y
>
> Hm, somehow I've never encountered this syntax, but it more looks like
> it means "default y if ARCH_OMAP2PLUS" instead of that.
>
> Checked this with menuconfig now:
> default ARCH_OMAP2PLUS
> resolves to:
> ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y]
>
> ..which might cause build break when OMAP is not selected, and
>
> depends on ARCH_OMAP2PLUS
> default y
> resolves to:
> ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y] && ARCH_OMAP2PLUS [=y]
>
> ..which should be randconfig friendly.
Yeah, you're right. Feel free to send a patch using your comments above
to describe that the current form is not randconfig friendly.
Kevin
prev parent reply other threads:[~2012-03-15 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 20:20 [GIT PULL] cpufreq: OMAP updates for v3.4 Kevin Hilman
2012-03-07 20:30 ` Dave Jones
2012-03-15 17:00 ` Kevin Hilman
2012-03-14 16:41 ` Grazvydas Ignotas
2012-03-14 16:44 ` Dave Jones
2012-03-14 17:22 ` Kevin Hilman
2012-03-14 17:38 ` Grazvydas Ignotas
2012-03-15 14:25 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obryc55k.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox