From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/9] cpuidle: Add common time keeping and irq enabling
Date: Wed, 29 Feb 2012 10:43:34 -0800 [thread overview]
Message-ID: <87obsheazt.fsf@ti.com> (raw)
In-Reply-To: <1330485109-7327-2-git-send-email-rob.lee@linaro.org> (Robert Lee's message of "Tue, 28 Feb 2012 21:11:41 -0600")
Robert Lee <rob.lee@linaro•org> writes:
> Make necessary changes to implement time keeping and irq enabling
> in the core cpuidle code. This will allow the removal of these
> functionalities from various platform cpuidle implementations whose
> timekeeping and irq enabling follows the form in this common code.
>
> Signed-off-by: Robert Lee <rob.lee@linaro•org>
> ---
> arch/arm/include/asm/cpuidle.h | 14 ++++++
> drivers/cpuidle/cpuidle.c | 90 ++++++++++++++++++++++++++++++++--------
> include/linux/cpuidle.h | 13 ++++++
> 3 files changed, 99 insertions(+), 18 deletions(-)
> create mode 100644 arch/arm/include/asm/cpuidle.h
>
> diff --git a/arch/arm/include/asm/cpuidle.h b/arch/arm/include/asm/cpuidle.h
> new file mode 100644
> index 0000000..1d2075b
> --- /dev/null
> +++ b/arch/arm/include/asm/cpuidle.h
> @@ -0,0 +1,14 @@
> +#ifndef __ASM_ARM_CPUIDLE_H
> +#define __ASM_ARM_CPUIDLE_H
> +
> +/* Common ARM WFI state */
> +#define CPUIDLE_ARM_WFI_STATE {\
> + .enter = cpuidle_simple_enter,\
> + .exit_latency = 1,\
> + .target_residency = 1,\
> + .flags = CPUIDLE_FLAG_TIME_VALID,\
> + .name = "WFI",\
> + .desc = "ARM core clock gating (WFI)",\
> +}
nit: just name this ARM WFI. Clock gating is platform specific, and
"core" has platform-specific meanings, so in order to keep this truly
generic, I think hat ARM WFI is the best name.
Kevin
next prev parent reply other threads:[~2012-02-29 18:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 3:11 [PATCH v6 0/9] Consolidate cpuidle functionality Robert Lee
2012-02-29 3:11 ` [PATCH v6 1/9] cpuidle: Add common time keeping and irq enabling Robert Lee
2012-02-29 8:30 ` Jean Pihet
2012-02-29 13:30 ` Rob Lee
2012-02-29 11:13 ` Deepthi Dharwar
2012-02-29 13:33 ` Rob Lee
2012-02-29 18:43 ` Kevin Hilman [this message]
2012-02-29 21:17 ` Rob Lee
2012-02-29 3:11 ` [PATCH v6 2/9] ARM: at91: Consolidate time keeping and irq enable Robert Lee
2012-02-29 3:11 ` [PATCH v6 3/9] ARM: exynos: " Robert Lee
2012-02-29 6:41 ` Amit Kachhap
2012-02-29 3:11 ` [PATCH v6 4/9] ARM: kirkwood: " Robert Lee
2012-02-29 3:11 ` [PATCH v6 5/9] ARM: davinci: " Robert Lee
2012-02-29 8:36 ` Jean Pihet
2012-02-29 13:36 ` Rob Lee
2012-02-29 3:11 ` [PATCH v6 6/9] ARM: omap: Consolidate OMAP3 " Robert Lee
2012-02-29 3:11 ` [PATCH v6 7/9] ARM: omap: Consolidate OMAP4 " Robert Lee
2012-02-29 3:11 ` [PATCH v6 8/9] ARM: shmobile: Consolidate " Robert Lee
2012-02-29 3:11 ` [PATCH v6 9/9] SH: " Robert Lee
2012-02-29 9:40 ` [PATCH v6 0/9] Consolidate cpuidle functionality Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obsheazt.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox