From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP4: cpuidle: Fix the C-state reporting to cpuidle governor.
Date: Tue, 14 Feb 2012 10:58:32 -0800 [thread overview]
Message-ID: <87obt16y3r.fsf@ti.com> (raw)
In-Reply-To: <4F3A1FB4.5010304@ti.com> (Santosh Shilimkar's message of "Tue, 14 Feb 2012 14:17:48 +0530")
Santosh Shilimkar <santosh.shilimkar@ti•com> writes:
> On Wednesday 08 February 2012 04:08 AM, Kevin Hilman wrote:
>> Santosh Shilimkar <santosh.shilimkar@ti•com> writes:
>>
>>> OMAP4 cpuidle driver is reporting the state requested by governor rather than
>>> the actually attempted one.
>>>
>>> This is obviously misleading sysfs and powertop cpuidle statistics.
>>> Fix it so that stats are reported correctly.
>>>
>>> Reported-by: Kevin Hilman <khilman@ti•com>
>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>>> ---
>>> arch/arm/mach-omap2/cpuidle44xx.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
>>> index cfdbb86..f128489 100644
>>> --- a/arch/arm/mach-omap2/cpuidle44xx.c
>>> +++ b/arch/arm/mach-omap2/cpuidle44xx.c
>>> @@ -85,6 +85,7 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
>>> cpu1_state = pwrdm_read_pwrst(cpu1_pd);
>>> if (cpu1_state != PWRDM_POWER_OFF) {
>>> new_state_idx = drv->safe_state_index;
>>> + index = drv->safe_state_index;
>>
>> How about just get rid of new_state_idx all together and just update
>> index and use it to index in to the states.
>>
> Make sense. Updated patch below.
>
> Regards,
> Santosh
>
> From 939dc3eda7895043c03526110e2a6b41e9861146 Mon Sep 17 00:00:00 2001
> From: Santosh Shilimkar <santosh.shilimkar@ti•com>
> Date: Sun, 5 Feb 2012 13:18:44 +0530
> Subject: [PATCH 2/2] ARM: OMAP4: cpuidle: Fix the C-state reporting to
> cpuidle governor.
>
> OMAP4 cpuidle driver is reporting the state requested by governor rather
> than
> the actually attempted one.
>
> This is obviously misleading sysfs and powertop cpuidle statistics.
> Fix it so that stats are reported correctly.
>
> While at this, get rid of new_state_idx, update and use
> index in to the states.
>
> Reported-by: Kevin Hilman <khilman@ti•com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
Perfect. Thanks.
Queuing as a fix for v3.3.
Kevin
prev parent reply other threads:[~2012-02-14 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 9:38 [PATCH] ARM: OMAP4: cpuidle: Fix the C-state reporting to cpuidle governor Santosh Shilimkar
2012-02-07 22:38 ` Kevin Hilman
2012-02-14 8:47 ` Santosh Shilimkar
2012-02-14 18:58 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obt16y3r.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox