From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 0/7] Add common cpuidle code for consolidation.
Date: Tue, 31 Jan 2012 13:55:19 -0800 [thread overview]
Message-ID: <87obtjlepk.fsf@ti.com> (raw)
In-Reply-To: <CAMXH7KF69QJ-WprR3i4dDxWKQSvDxwLx=Os-NqG+H1p12yM0uw@mail.gmail.com> (Rob Lee's message of "Mon, 30 Jan 2012 21:02:06 -0600")
Rob Lee <rob.lee@linaro•org> writes:
> On Tue, Jan 24, 2012 at 2:08 PM, Kevin Hilman <khilman@ti•com> wrote:
>> I noticed that the generic code uses ktime_get() for measuring time. On
>> OMAP, we use getnstimeofday() because I while back I remember having
>> problems with the interaction of CPUidle state measurements and system
>> suspend. Any idle activity during system suspend/resume ktime_get()
>> will WARN() because the timekeeping system has been suspended.
>
> It seems that all the time keeping functions including
> getnstimeofday() now have the "WARN_ON(timekeeping_suspended)" or
> WARN_ON_ONCE. ?So I'd like to stick with ktime_get unless I'm missing
> something about the suspend warning or unless there is some other
> reason why getnstieofday() is preferred.
I agree.
I've convinced myself that my use of getnstimeofday() is because of a
problem that doesn't exist anymore in mainline, and now that the
timekeeping core has been converted to use syscore_ops, use of
ktime_get() is good.
Kevin
prev parent reply other threads:[~2012-01-31 21:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 4:37 [PATCH v3 0/7] Add common cpuidle code for consolidation Robert Lee
2012-01-24 4:37 ` [PATCH v3 1/7] cpuidle: Add common init interface and idle functionality Robert Lee
2012-01-24 14:36 ` Rob Herring
2012-01-24 22:43 ` Rob Lee
2012-01-24 20:16 ` Kevin Hilman
2012-01-24 23:10 ` Rob Lee
2012-01-24 23:46 ` Turquette, Mike
2012-01-25 2:03 ` Rob Lee
2012-01-24 23:49 ` Daniel Lezcano
2012-01-25 2:38 ` Rob Lee
2012-01-25 14:52 ` Daniel Lezcano
2012-01-24 4:37 ` [PATCH v3 2/7] ARM: exynos: Modify to use new common cpuidle code Robert Lee
2012-01-29 4:47 ` Barry Song
2012-01-24 4:37 ` [PATCH v3 3/7] ARM: shmobile: " Robert Lee
2012-01-24 4:37 ` [PATCH v3 4/7] ARM: kirkwood: " Robert Lee
2012-01-24 4:37 ` [PATCH v3 5/7] ARM: davinci: " Robert Lee
2012-01-24 4:37 ` [PATCH v3 6/7] ARM: imx: Init imx5 gpc_dvfs clock for global use Robert Lee
2012-01-24 4:37 ` [PATCH v3 7/7] ARM: imx: Add imx5 cpuidle implementation Robert Lee
2012-01-24 20:08 ` [PATCH v3 0/7] Add common cpuidle code for consolidation Kevin Hilman
2012-01-24 20:17 ` Mark Brown
2012-01-25 0:41 ` Kevin Hilman
2012-01-25 0:46 ` Rob Lee
2012-01-25 18:58 ` Kevin Hilman
2012-01-29 15:34 ` Russell King - ARM Linux
2012-01-31 3:02 ` Rob Lee
2012-01-31 21:55 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obtjlepk.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox