From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] cpufreq: OMAP: fix build errors: depends on ARCH_OMAP2PLUS
Date: Fri, 13 Apr 2012 14:31:05 -0700 [thread overview]
Message-ID: <87pqbb5nfq.fsf@ti.com> (raw)
In-Reply-To: <20120413185322.GG25053@n2100.arm.linux.org.uk> (Russell King's message of "Fri, 13 Apr 2012 19:53:22 +0100")
Russell King - ARM Linux <linux@arm•linux.org.uk> writes:
> On Wed, Apr 04, 2012 at 03:20:22PM -0700, Kevin Hilman wrote:
>> Hi Dave,
>>
>> On 03/26/2012 05:19 PM, Kevin Hilman wrote:
>>> The OMAP driver needs a 'depends on ARCH_OMAP2PLUS' since it only
>>> builds for OMAP2+ platforms.
>>>
>>> This 'depends on' was in the original patch from Russell King, but was
>>> erroneously removed by me when making this option user-selectable in
>>> commit b09db45c (cpufreq: OMAP driver depends CPUfreq tables.) This
>>> patch remedies that.
>>>
>>> Apologies to Russell King for breaking his originally working patch.
>>>
>>> Also, thanks to Grazvydas Ignotas for reporting the same problem.
>>>
>>> Cc: Russell King<rmk+kernel@arm•linux.org.uk>
>>> Cc: Grazvydas Ignotas<notasas@gmail•com>
>>> Signed-off-by: Kevin Hilman<khilman@ti•com>
>>> ---
>>> Dave, this applies on top of your current fixes branch, and fixes a
>>> problem introduced there by me. Please merge for v3.4-rc. Thanks.
>>
>> Can you pick this up for v3.4-rc?
>
> Right, I'm fed up with chasing over this trivial patch. It's been almost
> a full month since the problem was first reported and it _still_ remains
> unfixed in mainline, despite me chasing over it. So, sorry, you lose.
>
> I'm merging my fix (attached) which I've been running against the nightly
> builds into my fixes branch and will ask Linus to pull it this weekend.
> If you want something else, then please send a patch on top of my fix to
> do what you want.
>
> Alternatively, send a replacement fix to Linus _before_ Sunday evening
> copying me with it and I'll drop this from my tree. But I want to see
> an alternative going to Linus for that to happen.
I've (re)sent the patches now.
I just resent the CPUfreq driver Kconfig fix, this time directly to Linus.
I also just resent the arch/arm/mach-omap2 one to Tony/Paul with a
slightly updated changelog making it clear that removing that dead code
also fixes build errors so it can be queued ASAP for v3.4-rc.
Combined, those fix the problems your patch addresses.
Kevin
next prev parent reply other threads:[~2012-04-13 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 0:19 [PATCH] cpufreq: OMAP: fix build errors: depends on ARCH_OMAP2PLUS Kevin Hilman
2012-03-30 13:12 ` Russell King - ARM Linux
2012-03-30 14:24 ` Kevin Hilman
2012-04-04 22:20 ` Kevin Hilman
2012-04-13 18:53 ` Russell King - ARM Linux
2012-04-13 21:31 ` Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-13 20:32 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqbb5nfq.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox