From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 8/8] arm: omap3: prevent per_clkdm from attempting manual domain transitions
Date: Wed, 15 Feb 2012 11:37:33 -0800 [thread overview]
Message-ID: <87pqdf99c2.fsf@ti.com> (raw)
In-Reply-To: <1329320274-481-9-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Wed, 15 Feb 2012 17:37:54 +0200")
Tero Kristo <t-kristo@ti•com> writes:
> Attempting this will cause problems especially with off-mode enabled.
Please be more verbose about the problems seen, and the root cause(s).
Kevin
> Previously this issue was hidden by the fact that per_clkdm never
> attempted manual idle by software, as the usecounts for the clockdomain
> were broken.
>
> Signed-off-by: Tero Kristo <t-kristo@ti•com>
> Cc: Paul Walmsley <paul@pwsan•com>
> Cc: Kevin Hilman <khilman@ti•com>
> ---
> arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> index b84e138..db31bbf 100644
> --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
> +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> @@ -282,7 +282,7 @@ static struct clockdomain usbhost_clkdm = {
> static struct clockdomain per_clkdm = {
> .name = "per_clkdm",
> .pwrdm = { .name = "per_pwrdm" },
> - .flags = CLKDM_CAN_HWSUP_SWSUP,
> + .flags = CLKDM_CAN_HWSUP_SWSUP | CLKDM_NO_MANUAL_TRANS,
> .dep_bit = OMAP3430_EN_PER_SHIFT,
> .wkdep_srcs = per_wkdeps,
> .sleepdep_srcs = per_sleepdeps,
next prev parent reply other threads:[~2012-02-15 19:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 15:37 [PATCHv2 0/8] arm: omap: clk/clkdm/pwrdm/voltdm usecounting changes Tero Kristo
2012-02-15 15:37 ` [PATCHv2 1/8] arm: omap: clk: add support for omap_clk_for_each Tero Kristo
2012-02-15 15:37 ` [PATCHv2 2/8] arm: omap3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-02-15 15:37 ` [PATCHv2 3/8] arm: omap3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-02-15 15:37 ` [PATCHv2 4/8] arm: omap3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-02-15 15:37 ` [PATCHv2 5/8] arm: omap3: set autoidle flags for a few clocks Tero Kristo
2012-02-15 15:37 ` [PATCHv2 6/8] arm: omap: pm-debug: enhanced usecount debug support Tero Kristo
2012-02-15 15:37 ` [PATCHv2 7/8] arm: omap: clockdomain: add support for preventing domain transitions Tero Kristo
2012-02-15 19:35 ` Kevin Hilman
2012-02-16 8:39 ` Tero Kristo
2012-02-16 8:43 ` Shilimkar, Santosh
2012-02-16 8:58 ` Tero Kristo
2012-02-15 15:37 ` [PATCHv2 8/8] arm: omap3: prevent per_clkdm from attempting manual " Tero Kristo
2012-02-15 19:37 ` Kevin Hilman [this message]
2012-02-16 8:57 ` Tero Kristo
2012-02-16 9:57 ` Shilimkar, Santosh
2012-02-16 13:15 ` Tero Kristo
2012-02-16 15:23 ` Tero Kristo
2012-02-16 15:45 ` Shilimkar, Santosh
2012-02-16 16:48 ` Tero Kristo
2012-02-16 17:31 ` Kevin Hilman
2012-02-17 9:28 ` Tero Kristo
2012-02-22 22:37 ` Kevin Hilman
2012-02-23 9:00 ` Tero Kristo
2012-02-24 10:11 ` Tero Kristo
2012-02-28 8:40 ` Tero Kristo
2012-02-28 23:05 ` Kevin Hilman
2012-02-29 8:01 ` Tero Kristo
2012-02-29 17:36 ` Tero Kristo
2012-02-15 22:30 ` [PATCHv2 0/8] arm: omap: clk/clkdm/pwrdm/voltdm usecounting changes Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqdf99c2.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox