From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv6 2/3] OMAP: I2C: Remove the reset in the init path
Date: Fri, 26 Aug 2011 16:11:18 -0700 [thread overview]
Message-ID: <87pqjrydih.fsf@ti.com> (raw)
In-Reply-To: <1312524035-5549-2-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Fri, 5 Aug 2011 11:30:34 +0530")
Shubhrajyoti D <shubhrajyoti@ti•com> writes:
> - The reset in the driver at init is not needed anymore as the
> hwmod framework takes care of reseting it.
> - Reset is removed from omap_i2c_init, which was called
> not only during probe, but also after time out and error handling.
> device_reset were added in those places to effect the reset.
> - Earlier the hwmod SYSC settings were over-written in the driver.
> Removing the same and letting the hwmod take care of the settings.
> - Clean up the SYSS_RESETDONE_MASK macro as it is no longer needed.
> - Clean up the SYSCONFIG SYSC bit defination macros.
> - Fix the typos in wakeup.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti•com>
I asked this in an earlier version, but here it is again.
Are you sure a full IP reset is needed on the timeout and error
conditions and not just the module-level one done by:
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
[ and later... ]
/* Take the I2C module out of reset: */
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);
I kind of suspect that the IP rese was done because the omap_i2c_init()
function was callled under the timeout/error conditions, but that a full
IP SW reset is a bit heavy handed.
Kevin
next prev parent reply other threads:[~2011-08-26 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 6:00 [PATCHv6 1/3] OMAP: I2C: Reset support Shubhrajyoti D
2011-08-05 6:00 ` [PATCHv6 2/3] OMAP: I2C: Remove the reset in the init path Shubhrajyoti D
2011-08-26 23:11 ` Kevin Hilman [this message]
2011-08-29 9:34 ` Shubhrajyoti
2011-08-05 6:00 ` [PATCHv6 3/3] OMAP: I2C: Remove the SYSC register definition Shubhrajyoti D
2011-08-26 23:06 ` [PATCHv6 1/3] OMAP: I2C: Reset support Kevin Hilman
2011-08-29 9:31 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqjrydih.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox