From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] rtc: pxa: fix rtc caculation issue
Date: Thu, 29 Nov 2012 21:04:06 +0100 [thread overview]
Message-ID: <87r4nc18i1.fsf@free.fr> (raw)
In-Reply-To: <1354155670-6267-2-git-send-email-chao.xie@marvell.com> (Chao Xie's message of "Wed, 28 Nov 2012 21:21:08 -0500")
Chao Xie <chao.xie@marvell•com> writes:
Hi Chao Xie,
First of all, could you please send patches from rtc-pxa to me also, as I'm
maintaining that driver ?
Second point, the original design of the driver relies on the special case of
writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
21.4.2.3.5 "Writing Alarm Registers with Invalid (Zero) Data", which states :
> Day-Of-Week (DOW), or Week-Of-Month (WOM), Day of Month (DOM), Month or Year
> fields?Zero is not valid for these fields. If zero is written into any of
> these fields, it is ignored while generating the alarm.
I'd like to know if your patch fixes something, or is an enhancement ?
Cheers.
--
Robert
PS: I've not checked the patch yet, that's just a prelimary comment on the patch
message.
next prev parent reply other threads:[~2012-11-29 20:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 2:21 [PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device Chao Xie
2012-11-29 2:21 ` [PATCH 2/4] rtc: pxa: fix rtc caculation issue Chao Xie
2012-11-29 20:04 ` Robert Jarzmik [this message]
2012-12-03 2:40 ` Chao Xie
2012-12-04 2:53 ` Chao Xie
2012-11-29 2:21 ` [PATCH 3/4] rtc: pxa: add pxa95x rtc support Chao Xie
2012-12-04 7:03 ` Haojian Zhuang
2012-11-29 2:21 ` [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device Chao Xie
2012-11-29 10:26 ` Russell King - ARM Linux
2012-11-29 20:10 ` Robert Jarzmik
2012-11-29 10:25 ` [PATCH 1/4] rtc: sa1100: enable/disable rtc " Russell King - ARM Linux
2012-11-30 7:04 ` Haojian Zhuang
2012-12-03 1:39 ` Chao Xie
2012-12-03 2:53 ` Chao Xie
2012-12-03 5:35 ` Haojian Zhuang
2012-12-03 5:42 ` Chao Xie
2012-12-03 9:48 ` Russell King - ARM Linux
2012-12-04 2:51 ` Chao Xie
2012-12-04 7:01 ` Haojian Zhuang
2012-12-03 5:33 ` Haojian Zhuang
2012-12-03 5:02 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4nc18i1.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox