From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] OMAP2+: UART: Fix incorrect population of default uart pads
Date: Mon, 07 May 2012 10:39:12 -0700 [thread overview]
Message-ID: <87r4uv51rz.fsf@ti.com> (raw)
In-Reply-To: <20120504172417.GE5613@atomide.com> (Tony Lindgren's message of "Fri, 4 May 2012 10:24:18 -0700")
Tony Lindgren <tony@atomide•com> writes:
> * Raja, Govindraj <govindraj.raja@ti•com> [120424 01:41]:
>> On Tue, Apr 24, 2012 at 5:15 AM, Kevin Hilman <khilman@ti•com> wrote:
>> > "Govindraj.R" <govindraj.raja@ti•com> writes:
>> >
>> >> From: "Govindraj.R" <govindraj.raja@ti•com>
>> >>
>> >> The following commit:
>> >> (7496ba3 ?ARM: OMAP2+: UART: Add default mux for all uarts)
>> >> added default pads for all uarts. But not all boards tend to
>> >> use all uarts and most of unused uart pins are muxed for
>> >> other purpose. This commit breaks the modules which where trying
>> >> to use unused uart pins on their boards.
>> >>
>> >> So remove the default pads adding.
>> >
>> > I just noticed that this patch breaks runtime PM & wakeups for UART
>> > console (at least on 3530/Overo with ttyO2 console.)
>> >
>> > By removing the pads, the initial device_init_wakeup() is not called on
>> > port init. ?Without this call serial_omap_pm() disables runtime PM
>> > because it checks device_may_wakeup().
>> >
>> > Since runtime PM was disabled, I manually re-enabled it and then enabled
>> > wakeups:
>> >
>> > ?echo auto > /sys/devices/platform/omap_uart.2/power/control
>> > ?echo enabled > /sys/devices/platform/omap_uart.2/tty/ttyO2/power/wakeup
>> >
>> > Then, after enabling auto-suspend timeouts, it seems wakeups are still
>> > not working since the console hangs.
>> >
>> > Reverting $SUBJECT patch gets things working again.
>>
>> This was decided as part of discussion [1]
>>
>> If we are _reconsidering_ taking this patch [2]
>> to dynamically probe uart pins and enable rx wakeup.
>>
>> I can re-work on the patch[2] as per tony's comments[1]
>> and re-post it.
>
> Just to follow up on this.. Let's first get things working reliably,
> and only then add more PM support.
>
> We absolutely can't revert $SUBJECT because it's known to mess up
> at least smsc911x and ehci on zoom3, hsi on n900 and probably
> many other things.
>
> For the -rc cycle, it seems that [2] is out of question at this point
> as too intrusive. If the PM & wakeups are broken in the default cases,
> then I suggest we just take few steps back and disable any deeper PM
> states in the -rc series.
Unfortunately, no need to do anything more to disable deeper PM states.
Because $SUBJECT disables runtime PM for UART, it keeps both PER and
CORE on all the time. :(
Kevin
next prev parent reply other threads:[~2012-05-07 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 13:40 [PATCH 0/2] OMAP2+: UART: Fix usage of default mux pads Govindraj.R
2012-04-10 13:40 ` [PATCH 1/2] OMAP2+: UART: Fix incorrect population of default uart pads Govindraj.R
2012-04-11 20:14 ` Russ Dill
2012-04-13 23:14 ` Russ Dill
2012-04-17 17:50 ` Tony Lindgren
2012-04-23 23:45 ` Kevin Hilman
2012-04-24 8:38 ` Raja, Govindraj
2012-05-04 17:24 ` Tony Lindgren
2012-05-07 17:39 ` Kevin Hilman [this message]
2012-05-07 17:54 ` Tony Lindgren
2012-04-10 13:40 ` [PATCH 2/2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup Govindraj.R
2012-04-10 16:11 ` Tony Lindgren
2012-04-10 16:40 ` Russ Dill
2012-04-11 11:50 ` Raja, Govindraj
2012-04-11 20:16 ` Russ Dill
2012-04-13 23:39 ` Russ Dill
2012-04-17 1:41 ` Tony Lindgren
2012-04-17 12:47 ` Raja, Govindraj
2012-04-17 17:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4uv51rz.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox