Subject: [PATCH] ARM: dove: fix legacy dove IRQ numbers for 3.18

From: [email-masked] (Robert Jarzmik)
Date: Sat, 13 Dec 2014 13:26:47 +0100

Russell King <[email-masked]> writes:

> v3.18 changed handle_IRQ() to call __handle_domain_irq(), which now
> rejects attempts to deliver IRQ0.  Since IRQ 0 is used as the timer
> interrupt (just like the PIT on x86), this causes boot to fail as the
> bogomips calibration never completes.
>
> Fix this by shuffling all interrupts up by one.
Hi Russell,

I was curious why shift by "one".
Why not shift by for example NR_IRQS_LEGACY ?

And even if you judge 1 is the right number, wouldn't it be better to define a
constant "IRQ_OFS" and have each define be "#define IRQ_xxxx (IRQ_OFS + <n>) ?

Cheers.

--
Robert