Subject: [PATCHv6 10/10] arm: mvebu: add .dts file for Synology DS414

From: [email-masked] (Arnaud Ebalard)
Date: Sat, 22 Nov 2014 08:41:10 +0100

Hi Ben,

Ben Peddell <[email-masked]> writes:

> On 22/11/14 09:46, Arnaud Ebalard wrote:
>> +
>> +	syno_id_bit0_pin: syno-id-bit0-pin {
>> +		marvell,pins = "mpp26";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_syno_id_bit1: syno-id-bit1-pin {
>> +		marvell,pins = "mpp28";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_syno_id_bit2: syno-id-bit2-pin {
>> +		marvell,pins = "mpp29";
>> +		marvell,function = "gpio";
>> +	};
>> +
>> +	pmx_fan1_alarm: fan1-alarm-pin {
>> +		marvell,pins = "mpp33";
>> +		marvell,function = "gpio";
>> +	};
>
> It looks like you forgot to replace pmx_* with *_pin here.

Indeed. Weird it went unnoticed during compilation. Thanks for
pointing it, Ben.

Cheers,

a+