From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 4/6] ARM: OMAP3 PM: Enable IO Wake up
Date: Thu, 01 Mar 2012 14:37:09 -0800 [thread overview]
Message-ID: <87sjhsdk2y.fsf@ti.com> (raw)
In-Reply-To: <4F4F1CBA.7040502@ti.com> (Rajendra Nayak's message of "Thu, 01 Mar 2012 12:22:42 +0530")
Rajendra Nayak <rnayak@ti•com> writes:
> On Wednesday 29 February 2012 07:56 PM, Tero Kristo wrote:
>> From: Vishwanath BS<vishwanath.bs@ti•com>
>>
>> Enable IO Wake up for OMAP3 as part of PM Init. Currently this has been
>> managed in cpuidle path which is not the right place. Subsequent patch
>> will remove IO Daisy chain handling in cpuidle path once daisy chain is
>> handled as part of hwmod mux.
>>
>> Signed-off-by: Vishwanath BS<vishwanath.bs@ti•com>
>> Tested-by: Govindraj.R<govindraj.raja@ti•com>
>> Signed-off-by: Tero Kristo<t-kristo@ti•com>
>> ---
>> arch/arm/mach-omap2/pm34xx.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
>> index e97ec3f..e6c2d39 100644
>> --- a/arch/arm/mach-omap2/pm34xx.c
>> +++ b/arch/arm/mach-omap2/pm34xx.c
>> @@ -793,6 +793,10 @@ static int __init omap3_pm_init(void)
>> goto err1;
>> }
>>
>> + if (omap3_has_io_wakeup())
>> + omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_MASK, WKUP_MOD,
>> + PM_WKEN);
>
> On OMAP4 this GLOBAL IO chain enable happens as part of the trigger
> function itself, it might make sense to do that for OMAP3 too to avoid
> similar issues as seen on OMAP4 when the GLOBAL switch is enabled too
> late in boot. The best however would be to get rid of it in the trigger
> function and enable this early during PM init, but I am not sure whats
> a good place to do this 'early' enough.
What about the subsys_initcall() that's already in the prm*.c files?
IMO, the global one-time init doesn't belong in the trigger function
because there's no need to do the extra PRM read/write when it should be
a one-shot init.
Kevin
next prev parent reply other threads:[~2012-03-01 22:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 14:26 [PATCHv3 0/6] ARM: OMAP3PLUS: IO daisychain support fixes Tero Kristo
2012-02-29 14:26 ` [PATCHv3 1/6] ARM: OMAP3 PM: correct enable/disable of daisy io chain Tero Kristo
2012-02-29 14:26 ` [PATCHv3 2/6] ARM: OMAP3 PM: Move IO Daisychain function to omap3 prm file Tero Kristo
2012-03-01 6:49 ` Rajendra Nayak
2012-03-01 8:28 ` Tero Kristo
2012-03-01 8:43 ` Rajendra Nayak
2012-02-29 14:26 ` [PATCHv3 3/6] ARM: OMAP4 PM: Add IO Daisychain support Tero Kristo
2012-02-29 14:26 ` [PATCHv3 4/6] ARM: OMAP3 PM: Enable IO Wake up Tero Kristo
2012-02-29 17:22 ` Paul Walmsley
2012-03-01 6:52 ` Rajendra Nayak
2012-03-01 8:25 ` Tero Kristo
2012-03-01 22:37 ` Kevin Hilman [this message]
2012-03-02 9:19 ` Tero Kristo
2012-03-02 9:23 ` Rajendra Nayak
2012-02-29 14:27 ` [PATCHv3 5/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Tero Kristo
2012-02-29 14:27 ` [PATCHv3 6/6] ARM: OMAP3 PM: Remove IO Daisychain control from cpuidle Tero Kristo
2012-03-06 0:32 ` [PATCHv3 0/6] ARM: OMAP3PLUS: IO daisychain support fixes Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjhsdk2y.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox