Subject: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

From: [email-masked] (Kevin Hilman)
Date: Wed, 10 Nov 2010 08:24:00 -0800

"G, Manjunath Kondaiah" <[email-masked]> writes:

>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman at deeprootsystems.com] 
>> Sent: Wednesday, November 10, 2010 3:56 AM
>> To: G, Manjunath Kondaiah
>> Cc: linux-omap at vger.kernel.org; 
>> linux-arm-kernel at lists.infradead.org; Cousson, Benoit; 
>> Shilimkar, Santosh
>> Subject: Re: [PATCH v3 10/13] OMAP: DMA: Convert DMA library 
>> into DMA platform Driver
>> 
>> "G, Manjunath Kondaiah" <[email-masked]> writes:
>> 
>> > Convert DMA library into DMA platform driver and make use
>> > of platform data provided by HWMOD data base for OMAP2PLUS onwards.
>> > For OMAP1 processors, the DMA driver in mach-omap uses resource
>> > structures for getting platform data.
>> >
>> > Signed-off-by: G, Manjunath Kondaiah <[email-masked]>
>> > Cc: Benoit Cousson <[email-masked]>
>> > Cc: Kevin Hilman <[email-masked]>
>> > Cc: Santosh Shilimkar <[email-masked]>
>> 
>> [...]
>> 
>> > diff --git a/arch/arm/mach-omap2/include/mach/dma.h 
>> b/arch/arm/mach-omap2/include/mach/dma.h
>> > index d0a7d5b..d13c5c0 100644
>> > --- a/arch/arm/mach-omap2/include/mach/dma.h
>> > +++ b/arch/arm/mach-omap2/include/mach/dma.h
>> > @@ -29,4 +29,7 @@
>> >  #ifndef __ASM_ARCH_OMAP2_DMA_H
>> >  #define __ASM_ARCH_OMAP2_DMA_H
>> >  
>> > +/* Should be part of hwmod data base ? */
>> > +#define OMAP_DMA4_LOGICAL_DMA_CH_COUNT	32	/* 
>> REVISIT: Is this 32 + 2? */
>> > +
>> 
>> There are no users of this in this patch, all users are removed.
>
> This macro is used in hwmod data base. Do you mean hard coding this
> value in hwmod db and remove header?

What I mean is that from a reviewers perspective of this patch, you
added a new #define that is not used anywhere in this patch.  a #define
should be added along with any users of it.

That being said, the number of channels of the DMA IP sounds like
something that should indeed be associated with the hwmod as it is a
fixed HW feature.

Kevin