From: khilman@deeprootsystems•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 02/11] omap2/3: Fix DEBUG_LL for omap zoom2/3
Date: Fri, 30 Apr 2010 13:55:23 -0700 [thread overview]
Message-ID: <87sk6cirt0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20100430203349.25812.64659.stgit@baageli.muru.com> (Tony Lindgren's message of "Fri\, 30 Apr 2010 13\:33\:50 -0700")
Tony Lindgren <tony@atomide•com> writes:
> Zoom2 and 3 have UARTs only on the external debug board.
> GPMC needs to be mapped early to use it for DEBUG_LL.
>
> Additionally, 0xfb000000 overlaps with other areas, so
> use 0xfa400000 for the virtual address instead.
>
> Note that with the pending serial.c patches you need to
> set console=ttyS0,115200n8 as it will be the only UART
> mapped. To use DEBUG_LL, you need to pass also earlyprintk
> in cmdline.
>
> Cc: Allen Pais <allen.pais@ti•com>
> Cc: Vikram Pandita <vikram.pandita@ti•com>
> Signed-off-by: Tony Lindgren <tony@atomide•com>
> ---
> arch/arm/kernel/head.S | 10 ++++++++++
> arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +-
> arch/arm/mach-omap2/include/mach/debug-macro.S | 4 ++--
> arch/arm/mach-omap2/io.c | 9 +++++++++
> arch/arm/plat-omap/include/plat/serial.h | 2 +-
> 5 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> index eb62bf9..fd870e1 100644
> --- a/arch/arm/kernel/head.S
> +++ b/arch/arm/kernel/head.S
> @@ -328,6 +328,16 @@ __create_page_tables:
> add r0, r4, #0xd8000000 >> 18
> str r3, [r0]
> #endif
> +#if defined(CONFIG_MACH_OMAP_ZOOM2) || defined(CONFIG_MACH_OMAP_ZOOM3)
> + /*
> + * Zoom2 and Zoom3 have UARTs only on the debug board.
> + * The debug board is connected to the GPMC.
> + */
> + add r0, r4, #0xfa000000 >> 18
> + orr r0, r0, #0x00400000 >> 18 @ ZOOM_UART_VIRT
> + orr r3, r7, #0x10000000 @ ZOOM_UART_BASE
> + str r3, [r0]
> +#endif
I don't see why this part is needed. The same mapping is done using
the .io_pg_offset in the machine description which is done just before
this in head.S
Kevin
next prev parent reply other threads:[~2010-04-30 20:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 20:33 [PATCH 00/11] omap2/3/4: Multi-omap updates to boot test with omap3_defconfig Tony Lindgren
2010-04-30 20:33 ` [PATCH 01/11] omap2/3/4: Fix multi.h when omap3 and omap4 are selected without omap2 Tony Lindgren
2010-04-30 20:33 ` [PATCH 02/11] omap2/3: Fix DEBUG_LL for omap zoom2/3 Tony Lindgren
2010-04-30 20:55 ` Kevin Hilman [this message]
2010-04-30 21:02 ` Tony Lindgren
2010-04-30 21:20 ` Kevin Hilman
2010-04-30 21:37 ` Pandita, Vikram
2010-04-30 21:53 ` Pandita, Vikram
2010-04-30 22:00 ` Kevin Hilman
2010-04-30 23:30 ` Tony Lindgren
2010-05-01 0:10 ` Kevin Hilman
2010-05-01 1:37 ` Tony Lindgren
2010-05-01 1:50 ` Tony Lindgren
2010-05-03 22:10 ` Pandita, Vikram
2010-05-04 0:40 ` Tony Lindgren
2010-05-04 0:57 ` [PATCH 02a/11] omap: Use a memory address for storing the debug port info instead of UART1 scratchpad Tony Lindgren
2010-05-04 0:58 ` [PATCH 02b/11] omap2/3: Fix DEBUG_LL for omap zoom2/3 Tony Lindgren
2010-05-04 17:33 ` Pandita, Vikram
2010-05-04 23:09 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 03/11] omap3: Fix compile for board-cm-t35 Tony Lindgren
2010-04-30 20:33 ` [PATCH 04/11] omap3: Remove non-muxable ball entries for 3630 Tony Lindgren
2010-04-30 20:33 ` [PATCH 05/11] omap4: Fix multiboot with CONFIG_PM and CONFIG_ARCH_OMAP3 selected Tony Lindgren
2010-04-30 20:33 ` [PATCH 06/11] omap4: Fix omap_l2_cache_init not to run for other omaps Tony Lindgren
2010-05-01 6:18 ` Shilimkar, Santosh
2010-05-01 17:46 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 07/11] omap2/3/4: Add new boards to omap3_defconfig Tony Lindgren
2010-04-30 20:34 ` [PATCH 08/11] omap2/3/4: Make omap3_defconfig usable on Nokia boards Tony Lindgren
2010-04-30 20:34 ` [PATCH 09/11] omap2/3/4: Update PMIC options for TWL and Menelaus chips Tony Lindgren
2010-04-30 20:34 ` [PATCH 10/11] omap2/3/4: Dissable CONFIG_PM_VERBOSE in omap3_defconfig Tony Lindgren
2010-04-30 20:34 ` [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP " Tony Lindgren
2010-04-30 20:50 ` Tony Lindgren
2010-05-04 0:52 ` Tony Lindgren
2010-05-04 7:26 ` Tomi Valkeinen
2010-05-04 14:40 ` Tony Lindgren
2010-05-04 14:50 ` Tomi Valkeinen
2010-05-04 19:23 ` Tony Lindgren
2010-05-05 17:32 ` Old DSS code broken as module (was "RE: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in omap3_defconfig") Aguirre, Sergio
2010-05-05 17:43 ` Tony Lindgren
2010-05-05 18:23 ` Aguirre, Sergio
2010-05-06 8:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk6cirt0.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox