public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: baruch@tkos•co.il (Baruch Siach)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] arm64: dts: add support for SolidRun Clearfog GT 8K
Date: Thu, 06 Sep 2018 18:13:16 +0300	[thread overview]
Message-ID: <87tvn24q2b.fsf@tkos.co.il> (raw)
In-Reply-To: <20180906125300.GA22121@lunn.ch>

Hi Andrew,

Andrew Lunn writes:
>> v2:
>>   * Add SATA node
>>
>>   * Set front button code to KEY_WPS_BUTTON
>>
>>   * Use LEDs labels more aligned to conversion
>
> Hi Baruch
>
> It would be good to say why you did not make it fully aligned to
> convention. What is wrong with "clearfog-gt-8k:green:led0"

I wasn't sure what the 'devicename' field translates to for on-board
LEDs. The leds-class.txt document recommends to leave blank
non-applicable fields. Existing DTs already have have labels like
"beaglebone:green:usr0", and "am3517evm:green:user_led_1". So I'm fine
with your suggestion.

>> +		mdio {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			switch0phy0: switch0phy0 at 11 {
>> +				reg = <0x11>;
>> +			};
>> +			switch0phy1: switch0phy1 at 12 {
>> +				reg = <0x12>;
>> +			};
>> +			switch0phy2: switch0phy2 at 13 {
>> +				reg = <0x13>;
>> +			};
>> +			switch0phy3: switch0phy3 at 14 {
>> +				reg = <0x14>;
>> +			};
>> +		};
>
> It would be nice to add a black line after each child node.
>
> Otherwise, this looks good.

Thanks for reviewing.

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

next prev parent reply	other threads:[~2018-09-06 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 11:19 [PATCH v2] arm64: dts: add support for SolidRun Clearfog GT 8K Baruch Siach
2018-09-06 12:53 ` Andrew Lunn
2018-09-06 15:13   ` Baruch Siach [this message]
2018-09-21 11:05     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvn24q2b.fsf@tkos.co.il \
    --to=baruch@tkos$(echo .)co.il \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox