From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/6] clk: add pxa clocks infrastructure
Date: Sat, 02 Aug 2014 18:46:00 +0200 [thread overview]
Message-ID: <87tx5usuuv.fsf@free.fr> (raw)
In-Reply-To: <CAN1soZyST84DNvK=zyj6EhOt0fswZ4SvOmMnWiCZsYmapxkhOg@mail.gmail.com> (Haojian Zhuang's message of "Sat, 2 Aug 2014 20:00:43 +0800")
Haojian Zhuang <haojian.zhuang@gmail•com> writes:
> On Thu, Jul 31, 2014 at 4:50 AM, Robert Jarzmik <robert.jarzmik@free•fr> wrote:
>> +void __init clkdev_pxa_register(int ckid, const char *con_id,
>> + const char *dev_id, struct clk *clk)
>> +{
>> + if (!IS_ERR(clk) && (ckid != CLK_NONE))
>
> Will you specify CLK_NONE in clock driver?
I haven't found a use yet (ie. pxa27x has no use for it, while for pxa3xx and
pxa25x I don't know yet).
I had put that here for a "CKEN" type clock which would be declared, but hidden
from device-tree. That's the meaning of "CLK_NONE", hidden from DT.
I can remove it if you think that there is no pxaXXX which needs this functionality.
> It seems that CLK_NONE isn't used in pxa27x clock driver. And pxa_clocks[0] is
> not used. Is it redundant?
Yes it is. pxa_clocks[0] is never filled by any clock.
Cheers.
--
Robert
next prev parent reply other threads:[~2014-08-02 16:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 20:50 [PATCH v3 0/6] Migrate PXA27x platforms to clock framework Robert Jarzmik
2014-07-30 20:50 ` [PATCH v3 1/6] clk: add pxa clocks infrastructure Robert Jarzmik
2014-08-02 12:00 ` Haojian Zhuang
2014-08-02 16:46 ` Robert Jarzmik [this message]
2014-07-30 20:51 ` [PATCH v3 2/6] clk: dts: document pxa clock binding Robert Jarzmik
2014-07-30 20:51 ` [PATCH v3 3/6] arm: pxa: add clock pll selection bits Robert Jarzmik
2014-07-30 20:51 ` [PATCH v3 4/6] clk: add pxa27x clock drivers Robert Jarzmik
2014-07-30 20:51 ` [PATCH v3 5/6] dts: add devicetree bindings for pxa27x clocks Robert Jarzmik
2014-07-30 20:51 ` [PATCH v3 6/6] arm: pxa: Transition pxa27x to clk framework Robert Jarzmik
2014-08-02 12:27 ` [PATCH v3 0/6] Migrate PXA27x platforms to clock framework Haojian Zhuang
2014-08-23 16:05 ` Robert Jarzmik
2014-08-23 18:54 ` Arnd Bergmann
2014-08-24 9:49 ` Robert Jarzmik
2014-08-24 11:13 ` Daniel Mack
2014-08-24 12:08 ` Arnd Bergmann
2014-09-03 18:49 ` Mike Turquette
2014-09-03 19:33 ` Arnd Bergmann
2014-09-04 19:29 ` Mike Turquette
2014-09-04 21:49 ` Arnd Bergmann
2014-09-05 4:15 ` Re : " robert.jarzmik at free.fr
2014-09-20 16:13 ` Robert Jarzmik
2014-09-30 19:52 ` Mike Turquette
2014-09-30 22:02 ` Robert Jarzmik
2014-09-30 22:10 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx5usuuv.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox