From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching.
Date: Fri, 04 May 2012 09:46:17 -0700 [thread overview]
Message-ID: <87txzvc2sm.fsf@ti.com> (raw)
In-Reply-To: <CAMQu2gxjEFK3p9CZ0i3ACWTGTQSM6ywMCWUQJg7PMyh2avvL=w@mail.gmail.com> (Santosh Shilimkar's message of "Fri, 4 May 2012 12:34:23 +0530")
"Shilimkar, Santosh" <santosh.shilimkar@ti•com> writes:
> On Fri, May 4, 2012 at 3:17 AM, Kevin Hilman <khilman@ti•com> wrote:
>> Santosh Shilimkar <santosh.shilimkar@ti•com> writes:
>>
>>> cpu_class_is_omap2() contains all OMAP2+ devices. So update the DMA code
>>> cpu checks accordingly so that there is no need to patch
>>> the file for any future OMAP2+ devices.
>>>
>>> In long run, all these attributes should come from hwmod dev_attr based
>>> on DMA IP version.
>>>
>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>>> ---
>>> ?arch/arm/mach-omap2/dma.c | ? ?2 +-
>>> ?arch/arm/plat-omap/dma.c ?| ? ?4 ++--
>>> ?2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
>>> index b19d849..2750bb9 100644
>>> --- a/arch/arm/mach-omap2/dma.c
>>> +++ b/arch/arm/mach-omap2/dma.c
>>> @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
>>>
>>> ? ? ? dma_stride ? ? ? ? ? ? ?= OMAP2_DMA_STRIDE;
>>> ? ? ? dma_common_ch_start ? ? = CSDP;
>>> - ? ? if (cpu_is_omap3630() || cpu_is_omap44xx())
>>> + ? ? if (omap_rev() >= OMAP3630_REV_ES1_0)
>>
>> It's not obvious (at least to me) that this is equivalent.
>>
>> For example, this will now be true on the TI81xx devices.
>>
> I see your point.
> On second thought, i decided to drop this hunk from the patch since
> the availability of the dma descriptor feature can be read from dma
> capability register. Will post another patch for it and also add it to
> the clean-up series.
>
> Updated $subject patch in the end of email.
>
> Regards
> Santosh
>
> From e42966bc56b1603e033b5b259564ae149b11a5d9 Mon Sep 17 00:00:00 2001
> From: Santosh Shilimkar <santosh.shilimkar@ti•com>
> Date: Sat, 28 Apr 2012 20:19:10 +0530
> Subject: [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to
> avoid future patching.
>
> cpu_class_is_omap2() contains all OMAP2+ devices. So update the DMA code
> cpu checks accordingly so that there is no need to patch
> the file for any future OMAP2+ devices.
>
> In long run, all these attributes should come from hwmod dev_attr based
> on DMA IP version.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
> ---
> Dropped the hunk for descriptor feature check based on OMAP cpu
> version since it can be handled with DMA hardware capability
> register read.
Right, this looks better.
Thanks,
Kevin
next prev parent reply other threads:[~2012-05-04 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 9:48 [PATCH 0/7] ARM: OMAP2+: Misc cleanup Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 1/7] ARM: OMAP4: Don't compile cm2xxx_3xxx.c for OMAP4 only builds Santosh Shilimkar
2012-05-08 5:09 ` Paul Walmsley
2012-05-08 6:09 ` Shilimkar, Santosh
2012-05-02 9:48 ` [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile Santosh Shilimkar
2012-05-02 9:56 ` Russell King - ARM Linux
2012-05-02 10:14 ` Shilimkar, Santosh
2012-05-02 15:49 ` Tony Lindgren
2012-05-02 9:48 ` [PATCH 3/7] ARM: OMAP4: Remove un-used WakeupGen register defines Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching Santosh Shilimkar
2012-05-03 21:47 ` Kevin Hilman
2012-05-04 7:04 ` Shilimkar, Santosh
2012-05-04 16:46 ` Kevin Hilman [this message]
2012-05-02 9:48 ` [PATCH 5/7] ARM: All OMAP2PLUS machines use omap2 directory so just add one entry Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 6/7] ARM: OMAP4: Reduce the static IO mapping Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 7/7] ARM: OMAP4+: Add prm and cm base init function Santosh Shilimkar
2012-05-08 5:15 ` Paul Walmsley
2012-05-08 6:13 ` Shilimkar, Santosh
2012-05-07 23:03 ` [PATCH 0/7] ARM: OMAP2+: Misc cleanup Tony Lindgren
2012-05-08 7:17 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txzvc2sm.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox