From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 07/10] arm/dts: omap4-panda: Add twl6030 and i2c EEPROM
Date: Wed, 14 Dec 2011 16:31:53 -0800 [thread overview]
Message-ID: <87ty52oeti.fsf@ti.com> (raw)
In-Reply-To: <4EE8D3D9.5020403@ti.com> (Benoit Cousson's message of "Wed, 14 Dec 2011 17:50:33 +0100")
"Cousson, Benoit" <b-cousson@ti•com> writes:
> Hi Kevin,
>
> On 12/14/2011 6:06 AM, Kevin Hilman wrote:
>> Hi Benoit,
>>
>> Benoit Cousson<b-cousson@ti•com> writes:
>>
>>> Update pandaboard dts file with required clock frequencies
>>> for the i2c client devices existing on pandaboard.
>>>
>>> Add the twl6030 node in i2c1 controller.
>>>
>>> This is the minimal support needed to boot OMAP4 boards
>>> without any crash.
>>> The support for all the features included in this MFD will be
>>> added later.
>>>
>>> Add a generic i2c EEPROM entry.
>>>
>>> Signed-off-by: Benoit Cousson<b-cousson@ti•com>
>>> Cc: Grant Likely<grant.likely@secretlab•ca>
>>> ---
>>> arch/arm/boot/dts/omap4-panda.dts | 45 +++++++++++++++++++++++++++++++++++++
>>> 1 files changed, 45 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts
>>> index 9755ad5..b66bcd6 100644
>>> --- a/arch/arm/boot/dts/omap4-panda.dts
>>> +++ b/arch/arm/boot/dts/omap4-panda.dts
>>> @@ -18,3 +18,48 @@
>>> reg =<0x80000000 0x40000000>; /* 1 GB */
>>> };
>>> };
>>> +
>>> +&i2c1 {
>>> + clock-frequency =<400000>;
>>> +
>>> + /*
>>> + * Integrated Power Management Chip
>>> + * http://www.ti.com/lit/ds/symlink/twl6030.pdf
>>> + */
>>> + twl at 48 {
>>> + compatible = "ti,twl6030";
>>> + reg =<0x48>;
>>> + /* SPI = 0, IRQ# = 7, 4 = active high level-sensitive */
>>> + interrupts =<0 7 4>; /* IRQ_SYS_1N cascaded to gic */
>>> + interrupt-controller;
>>> + #interrupt-cells =<1>;
>>> + interrupt-parent =<&gic>;
>>> +
>>> + /* twl is a MFD, so it will contain a bunch of sub-ips */
>>> + rtc {
>>> + compatible = "ti,twl4030-rtc";
>>> + interrupts =<11>;
>>> + };
>>
>> After seeing the mostly cut& paste in Rajendra's regulator series, I'm
>> wondering if it wouldn't be better to just have a twl4030.dtsi here
>> which has the RTC and all the regulators with the default voltage ranges
>> from the TWL data sheet.
>
> Yes, indeed, it is still small here but will become much bigger with
> the regulators.
> In fact twl6030 is a SoC like OMAP, so all the TWL specific internal
> details can be located in a single file.
> The board will just have to provide the i2c address and the IRQ information.
>
>> Not knowing much about how includes work in DT, would it then be
>> possible for board files to override things like default voltage ranges
>> for regulators?
>
> To be honest, I was wondering as well how to do that with the
> /include/ functionality :-)
> But I've just done a couple of DTC test, and this seems to be pretty
> straightforward.
>
> The boards will contain that:
> &i2c1 {
> clock-frequency = <400000>;
>
> twl: twl at 48 {
> reg = <0x48>;
> /* SPI = 0, IRQ# = 7, 4 = active high level-sensitive */
> interrupts = <0 7 4>; /* IRQ_SYS_1N cascaded to gic */
> interrupt-controller;
> interrupt-parent = <&gic>;
> };
> };
>
> /include/ "twl6030.dtsi"
>
Nice.
> ...
>
> And the twl6030.dtsi will contain that for the moment:
>
> /*
> * Integrated Power Management Chip
> * http://www.ti.com/lit/ds/symlink/twl6030.pdf
> */
> &twl {
> compatible = "ti,twl6030";
> #interrupt-cells = <1>;
>
> /* twl is a MFD, so it will contain a bunch of sub-ips */
> rtc {
> compatible = "ti,twl4030-rtc";
> interrupts = <11>;
> };
> };
>
> And then all the regulators from Rajendra's series will be there as well.
>
> This will avoid the duplication between sdp and panda. Beagle will
> need a twl4030.dtsi which is different than the twl6030.
Great!
> I'll update and repost the series soon.
Thanks,
Kevin
next prev parent reply other threads:[~2011-12-15 0:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:02 [PATCH v2 00/10] OMAP4: Add DT support for i2c and twl6030 Benoit Cousson
2011-12-09 14:02 ` [PATCH v2 01/10] ARM: OMAP2+: pm: Do not init statically the SR and voltage layer with DT Benoit Cousson
2012-01-04 18:04 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller Benoit Cousson
2011-12-14 1:06 ` Kevin Hilman
2012-01-04 13:36 ` Cousson, Benoit
2012-01-04 18:08 ` Grant Likely
2012-01-04 21:28 ` Kevin Hilman
2012-01-04 21:56 ` Grant Likely
2011-12-14 16:58 ` Rob Herring
2011-12-15 15:05 ` Cousson, Benoit
2011-12-15 15:48 ` Rob Herring
2011-12-15 16:09 ` Cousson, Benoit
2011-12-22 8:22 ` Shubhrajyoti
2011-12-09 14:02 ` [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030 Benoit Cousson
2011-12-19 12:03 ` Samuel Ortiz
2011-12-19 13:53 ` Cousson, Benoit
2012-01-04 18:12 ` Grant Likely
2012-01-05 10:21 ` Cousson, Benoit
2011-12-09 14:02 ` [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030 Benoit Cousson
2011-12-19 16:52 ` Cousson, Benoit
2011-12-26 1:18 ` Alessandro Zummo
2011-12-20 15:13 ` Cousson, Benoit
2012-01-04 18:13 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 05/10] arm/dts: OMAP4: Add i2c controller nodes Benoit Cousson
2012-01-04 18:13 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 06/10] arm/dts: OMAP3: " Benoit Cousson
2012-01-04 18:14 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 07/10] arm/dts: omap4-panda: Add twl6030 and i2c EEPROM Benoit Cousson
2011-12-14 5:06 ` Kevin Hilman
2011-12-14 16:50 ` Cousson, Benoit
2011-12-15 0:31 ` Kevin Hilman [this message]
2012-01-04 18:14 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 08/10] arm/dts: omap4-sdp: Add twl6030, i2c3 and i2c4 devices Benoit Cousson
2012-01-04 18:14 ` Grant Likely
2011-12-09 14:02 ` [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM Benoit Cousson
2012-01-04 18:15 ` Grant Likely
2012-01-09 23:24 ` Tabi Timur-B04825
2012-01-10 10:09 ` Cousson, Benoit
2011-12-09 14:02 ` [PATCH v2 10/10] ARM: OMAP2+: board-generic: Remove i2c static init Benoit Cousson
2012-01-04 18:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty52oeti.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox