Subject: Re: [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines

From: Gregory CLEMENT <[email-masked]>
Date: Thu, 10 Jan 2019 12:25:25 +0100

Hi Linus,
 
 On mar., janv. 08 2019, Linus Walleij <[email-masked]> wrote:

> These two lines are active high, not active low. The bug was
> found when we changed the kernel to respect the polarity defined
> in the device tree.
>
> Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
> Cc: Jamie Lentin <[email-masked]>
> Cc: Guenter Roeck <[email-masked]>
> Cc: Jason Cooper <[email-masked]>
> Cc: Andrew Lunn <[email-masked]>
> Cc: Gregory Clement <[email-masked]>
> Cc: Sebastian Hesselbarth <[email-masked]>
> Cc: Julien D'Ascenzio <[email-masked]>
> Reported-by: Julien D'Ascenzio <[email-masked]>
> Tested-by: Julien D'Ascenzio <[email-masked]>
> Signed-off-by: Linus Walleij <[email-masked]>

Applied on mvebu/fixes with tags from Andrew and Jamie

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> index cbaf06f2f78e..eb917462b219 100644
> --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> @@ -36,8 +36,8 @@
>  		compatible = "gpio-fan";
>  		pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
>  		pinctrl-names = "default";
> -		gpios = <&gpio1 14 GPIO_ACTIVE_LOW
> -			 &gpio1 13 GPIO_ACTIVE_LOW>;
> +		gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
> +			 &gpio1 13 GPIO_ACTIVE_HIGH>;
>  		gpio-fan,speed-map = <0    0
>  				      3000 1
>  				      6000 2>;
> -- 
> 2.19.2
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel