From: gregory.clement@bootlin•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: mvebu: armada-37xx-tbg: Balance devm_clk_get in probe
Date: Wed, 10 Oct 2018 20:06:42 +0200 [thread overview]
Message-ID: <87va69he19.fsf@bootlin.com> (raw)
In-Reply-To: <153919299293.119890.9655297515756412545@swboyd.mtv.corp.google.com> (Stephen Boyd's message of "Wed, 10 Oct 2018 10:36:32 -0700")
Hi Stephen,
On mer., oct. 10 2018, Stephen Boyd <sboyd@kernel•org> wrote:
> Quoting Gregory CLEMENT (2018-09-14 08:34:21)
>> The parent clock is get only to have its name, and then the clock is no
>> more used, so we can safely free it using devm_clk_put.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin•com>
>> ---
>> drivers/clk/mvebu/armada-37xx-tbg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/mvebu/armada-37xx-tbg.c b/drivers/clk/mvebu/armada-37xx-tbg.c
>> index 71f30149e80e..caaa91a41683 100644
>> --- a/drivers/clk/mvebu/armada-37xx-tbg.c
>> +++ b/drivers/clk/mvebu/armada-37xx-tbg.c
>> @@ -102,6 +102,7 @@ static int armada_3700_tbg_clock_probe(struct platform_device *pdev)
>> return -EINVAL;
>> }
>> parent_name = __clk_get_name(parent);
>> + devm_clk_put(dev, parent);
>
> So then why use devm_clk_get()? Please replace both so tha
> devm_clk_put() doesn't need to be used..
Indeed between the successful devm_clk_get and the devm_clk_put we don't
exit the function in error so I can use clk_get and clk_put.
Gregory
>
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> reg = devm_ioremap_resource(dev, res);
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2018-10-10 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 15:34 [PATCH] clk: mvebu: armada-37xx-tbg: Balance devm_clk_get in probe Gregory CLEMENT
2018-10-10 17:36 ` Stephen Boyd
2018-10-10 18:06 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va69he19.fsf@bootlin.com \
--to=gregory.clement@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox