From: eric@anholt•net (Eric Anholt)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/5] drm/blend: Add a generic alpha property
Date: Fri, 30 Mar 2018 13:37:36 -0700 [thread overview]
Message-ID: <87vadd5mgf.fsf@anholt.net> (raw)
In-Reply-To: <402e596049beb3429faf5981682d902c70325274.1520974361.git-series.maxime.ripard@bootlin.com>
Maxime Ripard <maxime.ripard@bootlin•com> writes:
> Some drivers duplicate the logic to create a property to store a per-plane
> alpha.
>
> This is especially useful if we ever want to support extra protocols for
> Wayland like:
> https://lists.freedesktop.org/archives/wayland-devel/2017-August/034741.html
>
> Let's create a helper in order to move that to the core.
> diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
> index 5a81e1b4c076..05eda2d57c77 100644
> --- a/drivers/gpu/drm/drm_blend.c
> +++ b/drivers/gpu/drm/drm_blend.c
> @@ -88,6 +88,12 @@
> * On top of this basic transformation additional properties can be exposed by
> * the driver:
> *
> + * alpha:
> + * Alpha is setup with drm_plane_create_alpha_property(). It controls the
s/setup/set up/
> + * plane-wide opacity, from transparent (0) to opaque (0xffff). It can be
> + * combined with pixel alpha.
> + * The alpha value is represented as premultiplied alpha.
I don't think this premultiplied comment makes any sense. What are you
saying it's premultiplied with? Maybe you mean that the output pixels
will have both their color and alpha channels multiplied by this alpha?
I'd just drop it.
Reviewed-by: Eric Anholt <eric@anholt•net>
We should probably do this property for vc4 at some point, too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180330/249a4627/attachment.sig>
next prev parent reply other threads:[~2018-03-30 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 20:54 [PATCH v4 0/5] drm/blend: Support generic plane-wide alpha Maxime Ripard
2018-03-13 20:54 ` [PATCH v4 1/5] drm/blend: Add a generic alpha property Maxime Ripard
2018-03-30 20:37 ` Eric Anholt [this message]
2018-04-04 9:15 ` Paul Kocialkowski
2018-04-04 9:46 ` Laurent Pinchart
2018-04-04 16:03 ` Eric Anholt
2018-04-04 8:47 ` Paul Kocialkowski
2018-03-13 20:54 ` [PATCH v4 2/5] drm/atmel-hclcdc: Convert to the new " Maxime Ripard
2018-03-13 20:54 ` [PATCH v4 3/5] drm/rcar-du: " Maxime Ripard
2018-03-13 20:54 ` [PATCH v4 4/5] drm/sun4i: Add support for plane alpha Maxime Ripard
2018-04-04 8:49 ` Paul Kocialkowski
2018-03-13 20:54 ` [PATCH v4 5/5] drm/docs: Remove the rcar alpha from the csv file Maxime Ripard
2018-03-26 7:47 ` [PATCH v4 0/5] drm/blend: Support generic plane-wide alpha Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vadd5mgf.fsf@anholt.net \
--to=eric@anholt$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox