From: eric@anholt•net (Eric Anholt)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] clk: bcm2835: Add support for programming the audio domain clocks.
Date: Thu, 10 Sep 2015 14:35:10 -0700 [thread overview]
Message-ID: <87vbbigdpt.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1441562263-19888-4-git-send-email-eric@anholt.net>
Eric Anholt <eric@anholt•net> writes:
> This adds support for enabling, disabling, and setting the rate of the
> audio domain clocks. It will be necessary for setting the pixel clock
> for HDMI in the VC4 driver and let us write a cpufreq driver. It will
> also improve compatibility with user changes to the firmware's
> config.txt, since our previous fixed clocks are unaware of it.
>
> The firmware also has support for configuring the clocks through the
> mailbox channel, but the pixel clock setup by the firmware doesn't
> work, and it's Raspberry Pi specific anyway. The only conflicts we
> should have with the firmware would be if we made firmware calls that
> result in clock management (like opening firmware V3D or ISP access,
> which we don't support in upstream), or on hardware over-thermal or
> under-voltage (when the firmware would rewrite PLLB to take the ARM
> out of overclock). If that happens, our cached .recalc_rate() results
> would be incorrect, but that's no worse than our current state where
> we used fixed clocks.
>
> The existing fixed clocks in the code are left in place to provide
> backwards compatibility with old device tree files.
>
> Signed-off-by: Eric Anholt <eric@anholt•net>
> ---
> + onecell->clk_num = BCM2835_CLOCK_COUNT;
> + onecell->clks = kzalloc(sizeof(*onecell->clks), GFP_KERNEL);
Review of another clock driver I wrote pointed out that I missed the
multiply by BCM2835_CLOCK_COUNT here. I'll send an updated version.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150910/904f40dd/attachment.sig>
next prev parent reply other threads:[~2015-09-10 21:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 17:57 Raspberry Pi native clock driver Eric Anholt
2015-09-06 17:57 ` [PATCH 1/4] clk: bcm2835: Move under bcm/ with other Broadcom SoC clk drivers Eric Anholt
2015-09-07 6:48 ` Lee Jones
2015-09-08 19:22 ` Stephen Boyd
2015-10-01 14:43 ` Lee Jones
2015-09-06 17:57 ` [PATCH 2/4] clk: bcm2835: Add binding docs for the new platform clock driver Eric Anholt
2015-09-06 17:57 ` [PATCH 3/4] clk: bcm2835: Add support for programming the audio domain clocks Eric Anholt
2015-09-10 21:35 ` Eric Anholt [this message]
2015-09-06 17:57 ` [PATCH 4/4] ARM: bcm2835: Switch to using the new clock driver support Eric Anholt
2015-12-21 11:51 ` Martin Sperl
2015-12-21 12:42 ` Stefan Wahren
2015-12-21 15:17 ` Martin Sperl
2015-12-21 18:08 ` Stefan Wahren
2015-12-21 18:32 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbbigdpt.fsf@eliezer.anholt.net \
--to=eric@anholt$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox