public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/4] dma: mmp_pdma: add support for residue reporting
Date: Mon, 26 Aug 2013 08:07:34 +0200	[thread overview]
Message-ID: <87vc2touhl.fsf@free.fr> (raw)
In-Reply-To: 20130825180615.GX6617@n2100.arm.linux.org.uk

Hi Russell,

Russell King - ARM Linux <linux@arm•linux.org.uk> writes:
> Even when there is a callback set, there's no requirement for the DMA
> engine driver to keep the descriptor around after it has been submitted -
> it is free to copy that data into whatever internal representation it
> requires and then discard the descriptor if it so wishes.

That means that a driver which wished to "resubmit" the descriptor has to
"rebuild it" again, no ?

I was under the impression that a descriptor had the guarantee to survive even
after completion. This comes from include/linux/dmaengine.h:168, in enum
dma_ctrl_flags comment :
 * @DMA_CTRL_ACK - if clear, the descriptor cannot be reused until the client
 *  acknowledges receipt, i.e. has has a chance to establish any dependency
 *  chains

The sentence "cannot be reused until" meant that after it could be reused.

And there are usecases for that, for example a video capture buffer. The source
for DMA is always the same (camera FIFO), the destination is always the same
(ie. the same scatter-gather). Why rebuild all the info to resubmit the same
descriptor ?

So is my understand incorrect, and in that case is there a way with dmaengine to
"resubmit" a descriptor, without going through the whole preparation ?

Cheers.

-- 
Robert

  reply	other threads:[~2013-08-26  6:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 17:05 [PATCH v4 0/4] dma: pdma: cyclic, residue, DMA_PRIVATE Daniel Mack
2013-08-16 17:05 ` [PATCH v4 1/4] dma: mmp_pdma: only complete one transaction from dma_do_tasklet() Daniel Mack
2013-08-20  2:27   ` Xiang Wang
2013-08-20  7:44     ` Daniel Mack
2013-08-25  1:15       ` Robert Jarzmik
2013-08-16 17:05 ` [PATCH v4 2/4] dma: mmp_pdma: add support for cyclic DMA descriptors Daniel Mack
2013-08-16 17:05 ` [PATCH v4 3/4] dma: mmp_pdma: add support for residue reporting Daniel Mack
2013-08-21 11:35   ` Xiang Wang
2013-08-21 11:52     ` Andy Shevchenko
2013-08-21 12:03       ` Daniel Mack
2013-08-21 12:08         ` Andy Shevchenko
2013-08-25 16:11         ` Vinod Koul
2013-08-25 17:01           ` Russell King - ARM Linux
2013-08-25 16:48             ` Vinod Koul
2013-08-25 18:06               ` Russell King - ARM Linux
2013-08-26  6:07                 ` Robert Jarzmik [this message]
2013-08-21 11:55     ` Daniel Mack
2013-08-16 17:05 ` [PATCH v4 4/4] dma: mmp_pdma: set DMA_PRIVATE Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc2touhl.fsf@free.fr \
    --to=robert.jarzmik@free$(echo .)fr \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox