Subject: [RFC] Add .dts file for Netgear ReadyNAS 102

From: [email-masked] (Arnaud Ebalard)
Date: Wed, 03 Jul 2013 01:27:31 +0200

Hi,

Sebastian Hesselbarth <[email-masked]> writes:

>> +			pinctrl {
>> +				power_led_pin: power-led-pin {
>> +					marvell,pins = "mpp57";
>> +					marvell,function = "gpio";
>> +				};
>> +				sata1_led_pin: sata1-led-pin {
>> +					marvell,pins = "mpp15";
>> +					marvell,function = "gpio";
>> +				};
>> +
>> +				sata2_led_pin: sata2-led-pin {
>> +					marvell,pins = "mpp14";
>> +					marvell,function = "gpio";
>> +				};
>> +
>> +				backup_led_pin: backup-led-pin {
>> +					marvell,pins = "mpp56";
>> +					marvell,function = "gpio";
>> +				};
>> +			};
>> +
>> +			gpio_leds {
>
> Arnaud,
>
> gpio_leds, gpio_keys, and clocks nodes shouldn't be children of
> soc/internal-regs. I suggest to move them up as siblings of soc,
> memory, and chosen instead.

Will do that in next round. Thanks for pointing it.

Cheers,

a+