From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support
Date: Fri, 07 Oct 2011 15:50:32 -0700 [thread overview]
Message-ID: <87vcs0ifgn.fsf@ti.com> (raw)
In-Reply-To: <87d3e8juqm.fsf@ti.com> (Kevin Hilman's message of "Fri, 07 Oct 2011 15:35:13 -0700")
Kevin Hilman <khilman@ti•com> writes:
> Hi Santosh,
>
> Santosh Shilimkar <santosh.shilimkar@ti•com> writes:
>
>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for
>> suspend (S2R), CPU hotplug and CPUidle.
>
> Just noticed when doing some final build/sanity testing that there are a
> few of compile/link warnings/problems when the kernel is built without
> CONFIG_PM
>
> Some warnings:
>
> /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used
> /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used
>
> and some failures (these happen when CONFIG_SUSPEND=n but CONFIG_PM_RUNTIME=y:
>
> arch/arm/mach-omap2/built-in.o: In function `skip_l2en':
> /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume'
> arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
> /work/kernel/omap/pm/arch/arm/mach-omap2/pm34xx.c:429: undefined reference to `cpu_suspend'
> arch/arm/mach-omap2/built-in.o: In function `skipl2reen':
> /work/kernel/omap/pm/arch/arm/mach-omap2/sleep34xx.S:534: undefined reference to `cpu_resume'
> arch/arm/mach-omap2/built-in.o: In function `omap4_enter_lowpower':
> /work/kernel/omap/pm/arch/arm/mach-omap2/omap-mpuss-lowpower.c:281: undefined reference to `cpu_suspend'
>
> Turns out these are not directly related to your series and OMAP3
> exhibits the same problems.
>
> I just posted a patch[1] to attempt to address these.
>
> But could you fixup the first problem and test with [1] to see if things
> still build/work as expected.
OK, ignore my patch.
Arnd already has a fix for these link problems in his randconfig/arm
branch.
Please just cleanup the wakeupgen compile warnings and update your
branch.
Kevin
next prev parent reply other threads:[~2011-10-07 22:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 6:14 [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 01/24] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 02/24] OMAP4: Export omap4_get_base*() rather than global address pointers Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 03/24] OMAP4: PM: Add SAR RAM support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 04/24] OMAP4: PM: Keep static dep between MPUSS-EMIF and MPUSS-L3/L4 and DUCATI-L3 Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 05/24] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0 Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 06/24] OMAP4: PM: Initialise all the clockdomains to supported states Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 07/24] OMAP: Add Secure HAL and monitor mode API infrastructure Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 08/24] OMAP: PM: Add support to allocate the memory for secure RAM Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 09/24] OMAP4: PM: Add WakeupGen module as OMAP gic_arch_extn Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 10/24] OMAP4: PM: Add CPUX OFF mode support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 11/24] OMAP4: Remove __INIT from omap_secondary_startup() to re-use it for hotplug Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 12/24] OMAP4: PM: Program CPU1 to hit OFF when off-lined Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 13/24] OMAP4: PM: CPU1 wakeup workaround from Low power modes Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 14/24] OMAP4: PM: Use custom omap_do_wfi() for default idle Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 15/24] OMAP4: suspend: Add MPUSS power domain RETENTION support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 16/24] OMAP4: Remove un-used do_wfi() macro Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 17/24] OMAP4: PM: Add WakeupGen and secure GIC low power support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 18/24] OMAP4: PM: Add L2X0 cache lowpower support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 19/24] OMAP4: PM: Add MPUSS power domain OSWR support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 20/24] OMAP4: PM: Add power domain statistics support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 21/24] OMAP4: PM: Add CPUidle support Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 22/24] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 23/24] OMAP3: CPUidle: Make use of CPU PM notifiers Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 24/24] OMAP4: Fix errata i688 with MPU interconnect barriers Santosh Shilimkar
2011-10-04 17:05 ` [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Kevin Hilman
2011-10-05 7:43 ` Santosh Shilimkar
2011-10-07 22:35 ` Kevin Hilman
2011-10-07 22:50 ` Kevin Hilman [this message]
2011-10-08 8:44 ` Santosh Shilimkar
2011-10-10 18:01 ` Kevin Hilman
2011-10-11 7:09 ` Santosh Shilimkar
2011-10-11 17:00 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcs0ifgn.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox