From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error
Date: Mon, 06 Aug 2012 17:28:44 -0700 [thread overview]
Message-ID: <87wr1b35qb.fsf@ti.com> (raw)
In-Reply-To: <1340761532-27231-1-git-send-email-khilman@ti.com> (Kevin Hilman's message of "Tue, 26 Jun 2012 18:45:32 -0700")
Hi Wolfram,
Kevin Hilman <khilman@ti•com> writes:
> In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on
> failure.
>
> Without this, after a failed xfer, the runtime PM usecount will have
> been incremented, but not decremented causing the usecount to never
> reach zero after a failure. This keeps the device always runtime PM
> enabled which keeps the enclosing power domain active, and prevents
> full-chip retention/off from happening during idle.
>
> Cc: Shubhrajyoti D <shubhrajyoti@ti•com>
> Signed-off-by: Kevin Hilman <khilman@ti•com>
> ---
> This patch applies to current i2c-embedded/for-next branch
This one is needed for v3.6. Can you queue this up as a fix for
v3.6-rc?
Thanks,
Kevin
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 9895fa7..b105733 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -582,7 +582,7 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>
> r = pm_runtime_get_sync(dev->dev);
> if (IS_ERR_VALUE(r))
> - return r;
> + goto out;
>
> r = omap_i2c_wait_for_bb(dev);
> if (r < 0)
next prev parent reply other threads:[~2012-08-07 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 1:45 [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error Kevin Hilman
2012-06-27 6:11 ` Shubhrajyoti Datta
2012-06-28 21:55 ` Kevin Hilman
2012-06-29 5:47 ` Shubhrajyoti
2012-08-07 0:28 ` Kevin Hilman [this message]
2012-08-18 8:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr1b35qb.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox