From: khilman@deeprootsystems•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 00/11] OMAP: Serial: Add omap-serial driver with platform support
Date: Mon, 20 Sep 2010 09:21:19 -0700 [thread overview]
Message-ID: <87wrqg2xog.fsf@deeprootsystems.com> (raw)
In-Reply-To: <AANLkTik-+RC7y=dJnDdxzrqMFnTzRV-j8s5FtmMy8ZhE@mail.gmail.com> (Govindraj's message of "Sat, 18 Sep 2010 14:47:22 +0530")
Govindraj <govindraj.ti@gmail•com> writes:
> On Sat, Sep 18, 2010 at 5:11 AM, Kevin Hilman
> <khilman@deeprootsystems•com> wrote:
>> "Govindraj.R" <govindraj.raja@ti•com> writes:
>>
>>> This patch series adds a serial driver to handle uarts on omap platforms.
>>> Currenlty omap-uarts are handled with 8250 driver, since updating
>>> this driver with omap specific features will over load
>>> the 8250 driver with all omap-specific data thus a new driver
>>> is added to configure and support features like
>>> dma, h/w, s/w flowcontrol for omap-uarts.
>>> Also the patch series updates various low level platform specific
>>> serial data to support omap-uarts with hwmod framework and adds support
>>> for uart4 on OMAP3630.
>>
>> This series is missing a couple things to work more broadly on all
>> boards, specifically 3630-based boards.
>>
>> First, due to the current UART idle code base, you need to enable all
>> OMAP UARTs 36xx. ?Enabling less than all OMAP UARTs will break the
>> current idle code. ?As we discussed, the next phase we will move the
>> idle management from this serial.c hackery into the omap-serial driver
>> iteself. ?Until then, you need to call omap_serial_init() on
>> Zoom2/Zoom3. ?Patch below[1]
>>
>> Also, you previously had a patch that updated omap_uart_idle_init() to
>> handle 36xx and specifically UART4. ?Without that, struct
>> omap_uart_state is not setup correctly for UART4, and thus cannot be
>> properly idled on 3630.
>
> ok fine, I will I incorporate initialize all uarts patch for zoom boards.
>
> Are you referring to this patch?
> https://patchwork.kernel.org/patch/108066/
>
> Is this still needed if we have initialized all uarts?
> This patch might not needed if we have initialized all uarts right?
Right. We don't need the above patchwork patch if all UARTs are
initialized.
The other patch I was referring to was the one that added UART4 support
to omap_uart_idle_init() (added the wk_en, wk_st, padconf etc.) I had a
pending request for you to drop the muxmode from that patch, but the
rest of it was still needed.
>>
>> Also, it's been a while since I tested this on OMAP2. ?Please re-test on
>> OMAP2 with the whole series. ?Also, please report here the other
>> platforms this was tested on. ?The final needs to be tested on OMAP2, 3
>> and 4 before merge.
>
> Yes Sure,
>
> Just FYI this patch series was also tested on omap2,3,4.
>
OK, be sure to test Zoom3, because my testing on Zoom3 led to a crash as
soon as idle was enabled due to the missing init of all UARTs.
Thanks,
Kevin
next prev parent reply other threads:[~2010-09-20 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 16:05 [PATCH 00/11] OMAP: Serial: Add omap-serial driver with platform support Govindraj.R
2010-09-17 23:41 ` Kevin Hilman
2010-09-18 9:17 ` Govindraj
2010-09-20 16:21 ` Kevin Hilman [this message]
2010-09-21 15:37 ` Govindraj
2010-09-21 20:05 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrqg2xog.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox