From: Daniel Lezcano <daniel.lezcano@oss•qualcomm.com>
To: linux-kernel-dev@aliel•fr,
Neil Armstrong <neil.armstrong@linaro•org>,
Daniel Lezcano <daniel.lezcano@kernel•org>,
Zhang Rui <rui.zhang@intel•com>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Lukasz Luba <lukasz.luba@arm•com>
Cc: Guillaume La Roque <glaroque@baylibre•com>,
Kevin Hilman <khilman@baylibre•com>,
Jerome Brunet <jbrunet@baylibre•com>,
Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
linux-arm-kernel@lists•infradead.org,
linux-amlogic@lists•infradead.org, linux-kernel@vger•kernel.org,
linux-pm@vger•kernel.org, Mark Brown <broonie@kernel•org>,
kernel test robot <lkp@intel•com>
Subject: Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
Date: Tue, 2 Jun 2026 18:01:13 +0200 [thread overview]
Message-ID: <9adbe3cb-d42e-4b89-b6d7-62dd58b98e15@oss.qualcomm.com> (raw)
In-Reply-To: <20260602-fix-missing-meson_sm-symbol-v3-1-6f7f69cd7d6c@aliel.fr>
On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel•fr>
>
> The amlogic thermal driver calls meson_sm_get() and
> meson_sm_get_thermal_calib() which are exported by the meson_sm
> driver. Without CONFIG_MESON_SM enabled, the build fails with
> undefined references to these symbols.
>
> Add a proper Kconfig dependency on MESON_SM instead of relying on
> stub functions, which makes the dependency explicit and prevents
> invalid configurations.
>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/
> Reported-by: Mark Brown <broonie@kernel•org>
> Reported-by: kernel test robot <lkp@intel•com>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel•fr>
> ---
> Changes in v3:
> - Add a dependency on MESON_SM instead of stub functions.
> - Link to v2: https://lore.kernel.org/r/20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr
>
> Changes in v2:
> - Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM)
> to cover builtin and module in config.
> - Add missing trailers for kernel test robot.
> - Link to v1: https://lore.kernel.org/r/20260530-fix-missing-meson_sm-symbol-v1-1-3fb672b989d4@aliel.fr
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 1c4a5cd5a23ee..810eeccedfbab 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
> tristate "Amlogic Thermal Support"
> default ARCH_MESON
> depends on OF && ARCH_MESON
> + depends on MESON_SM
> help
> If you say yes here you get support for Amlogic Thermal
> for G12 SoC Family.
Did you forget to remove the stubs ?
next prev parent reply other threads:[~2026-06-02 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 14:19 [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM Ronald Claveau via B4 Relay
2026-06-02 16:01 ` Daniel Lezcano [this message]
2026-06-02 16:26 ` linux-kernel-dev
2026-06-02 21:08 ` Daniel Lezcano
2026-06-03 5:36 ` linux-kernel-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9adbe3cb-d42e-4b89-b6d7-62dd58b98e15@oss.qualcomm.com \
--to=daniel.lezcano@oss$(echo .)qualcomm.com \
--cc=broonie@kernel$(echo .)org \
--cc=daniel.lezcano@kernel$(echo .)org \
--cc=glaroque@baylibre$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel-dev@aliel$(echo .)fr \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=lukasz.luba@arm$(echo .)com \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox