From: Josh Law <joshlaw48@gmail•com>
To: ardb+git@google•com
Cc: ardb@kernel•org, arnd@arndb•de, ebiggers@kernel•org, hch@lst•de,
linux-arm-kernel@lists•infradead.org,
linux-crypto@vger•kernel.org, linux-raid@vger•kernel.org,
linux@armlinux•org.uk
Subject: Re: [PATCH 6/8] crypto: aegis128 - Use neon-intrinsics.h on ARM too
Date: Wed, 22 Apr 2026 19:19:31 +0100 [thread overview]
Message-ID: <C4E4FF7A-8CCD-44CA-8AD9-5BA8D177E1DF@gmail.com> (raw)
In-Reply-To: <20260422171655.3437334-16-ardb+git@google.com>
Hi ard, this is a good cleanup!
Being able to drop <arm_neon.h> and just using
<asm/neon-intrinsics.h> across both architectures makes the C code much
cleaner.
-# Enable <arm_neon.h>
-CFLAGS_aegis128-neon-inner.o += -isystem $(shell $(CC) -print-file-name=include)
Getting rid of the isystem is good. iirc that was a hack anyway, feel free
to correct me on that
Reviewed-by: Josh Law <joshlaw48@gmail•com>
next prev parent reply other threads:[~2026-04-22 18:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 17:16 [PATCH 0/8] ARM crc64 and XOR using NEON intrinsics Ard Biesheuvel
2026-04-22 17:16 ` [PATCH 1/8] ARM: Add a neon-intrinsics.h header like on arm64 Ard Biesheuvel
2026-04-22 17:16 ` [PATCH 2/8] xor/arm: Replace vectorized implementation with arm64's intrinsics Ard Biesheuvel
2026-04-22 18:07 ` Josh Law
2026-04-23 7:44 ` Christoph Hellwig
2026-04-22 17:16 ` [PATCH 3/8] xor/arm64: Use shared NEON intrinsics implementation from 32-bit ARM Ard Biesheuvel
2026-04-22 18:11 ` Josh Law
2026-04-23 7:46 ` Christoph Hellwig
2026-04-23 7:48 ` Ard Biesheuvel
2026-04-22 17:17 ` [PATCH 4/8] lib/crc: Turn NEON intrinsics crc64 implementation into common code Ard Biesheuvel
2026-04-22 18:13 ` Josh Law
2026-04-22 17:17 ` [PATCH 5/8] lib/crc: arm: Enable arm64's NEON intrinsics implementation of crc64 Ard Biesheuvel
2026-04-22 18:16 ` Josh Law
2026-04-22 17:17 ` [PATCH 6/8] crypto: aegis128 - Use neon-intrinsics.h on ARM too Ard Biesheuvel
2026-04-22 18:19 ` Josh Law [this message]
2026-04-22 17:17 ` [PATCH 7/8] lib/raid6: Include asm/neon-intrinsics.h rather than arm_neon.h Ard Biesheuvel
2026-04-22 18:20 ` Josh Law
2026-04-23 7:47 ` Christoph Hellwig
2026-05-09 20:23 ` Eric Biggers
2026-05-11 12:28 ` Christoph Hellwig
2026-05-27 1:57 ` Eric Biggers
2026-05-27 15:42 ` Ard Biesheuvel
2026-04-22 17:17 ` [PATCH 8/8] ARM: Remove hacked-up asm/types.h header Ard Biesheuvel
2026-05-09 20:05 ` Eric Biggers
2026-05-09 20:33 ` Arnd Bergmann
2026-05-28 20:35 ` [PATCH 0/8] ARM crc64 and XOR using NEON intrinsics Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4E4FF7A-8CCD-44CA-8AD9-5BA8D177E1DF@gmail.com \
--to=joshlaw48@gmail$(echo .)com \
--cc=ardb+git@google$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=ebiggers@kernel$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox