From: "Luca Ceresoli" <luca.ceresoli@bootlin•com>
To: "Gyeyoung Baek" <gye976@gmail•com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Rob Clark" <robin.clark@oss•qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel•org>,
"Abhinav Kumar" <abhinav.kumar@linux•dev>,
"Jessica Zhang" <jesszhan0024@gmail•com>,
"Sean Paul" <sean@poorly•run>,
"Marijn Suijten" <marijn.suijten@somainline•org>,
"Tian Tao" <tiantao6@hisilicon•com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon•com>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"John Stultz" <jstultz@google•com>,
"Andrzej Hajda" <andrzej.hajda@intel•com>,
"Neil Armstrong" <neil.armstrong@linaro•org>,
"Robert Foss" <rfoss@kernel•org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard•com>,
"Jonas Karlman" <jonas@kwiboo•se>,
"Jernej Skrabec" <jernej.skrabec@gmail•com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard•com>,
"Michal Simek" <michal.simek@amd•com>,
"Hui Pu" <Hui.Pu@gehealthcare•com>,
"Ian Ray" <ian.ray@gehealthcare•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
<dri-devel@lists•freedesktop.org>, <linux-kernel@vger•kernel.org>,
<linux-arm-msm@vger•kernel.org>,
<freedreno@lists•freedesktop.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2 07/11] drm/bridge: lt9611: switch to of_drm_get_bridge_by_endpoint()
Date: Tue, 28 Apr 2026 15:53:27 +0200 [thread overview]
Message-ID: <DI4U6SPMW5GG.34DH11UKWPUEX@bootlin.com> (raw)
In-Reply-To: <CAKbEznt-PUvg48tegibw+0xYCCvK+1jwESnuHx9+MG0p3MD5gA@mail.gmail.com>
On Tue Apr 28, 2026 at 3:18 PM CEST, Gyeyoung Baek wrote:
>>
>> @@ -1058,7 +1057,11 @@ static int lt9611_parse_dt(struct device *dev,
>>
>> lt9611->ac_mode = of_property_read_bool(dev->of_node, "lt,ac-mode");
>>
>> - return drm_of_find_panel_or_bridge(dev->of_node, 2, -1, NULL, <9611->next_bridge);
>> + lt9611->bridge.next_bridge = of_drm_get_bridge_by_endpoint(dev->of_node, 2, -1);
>> + if (IS_ERR(lt9611->bridge.next_bridge))
>> + return PTR_ERR(lt9611->bridge.next_bridge);
>> +
>> + return 0;
>> }
>
> Hello Luca,
> Could you take a look at this alternative?
> ------
> struct drm_bridge *next_bridge =
> of_drm_get_bridge_by_endpoint(dev->of_node, 2, -1);
>
> if (IS_ERR(next_bridge))
> return PTR_ERR(next_bridge);
>
> lt9611->bridge.next_bridge = next_bridge;
> return 0;
> ------
>
> I think it reads a bit cleaner and avoids holding the ERR_PTR in the struct.
Yes, but more verbose.
Based on this and the patch 8 fallback reported by Biju, I started
wondering whether the v1 version of this function, while being a bit ugly,
was leading to cleaner code... An example: [0].
Dmitry, your opinion?
[0] https://lore.kernel.org/all/20260413-drm-bridge-alloc-getput-panel_or_bridge-v1-6-acd01cd79a1f@bootlin.com/
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-04-28 13:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 9:15 [PATCH v2 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-04-28 9:15 ` [PATCH v2 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR Luca Ceresoli
2026-04-28 11:29 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-04-28 11:30 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-04-28 11:31 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-04-28 9:15 ` [PATCH v2 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-04-28 11:36 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-04-28 11:31 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-04-28 11:32 ` Dmitry Baryshkov
2026-04-28 13:18 ` Gyeyoung Baek
2026-04-28 13:53 ` Luca Ceresoli [this message]
2026-04-28 9:15 ` [PATCH v2 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-04-28 11:34 ` Dmitry Baryshkov
2026-04-28 11:49 ` Biju Das
2026-04-28 11:58 ` Biju Das
2026-04-28 13:19 ` Luca Ceresoli
2026-04-28 13:31 ` Biju Das
2026-04-28 13:47 ` Luca Ceresoli
2026-04-28 14:02 ` Biju Das
2026-04-28 14:38 ` Biju Das
2026-04-28 14:45 ` Biju Das
2026-04-28 15:19 ` Luca Ceresoli
2026-04-28 9:15 ` [PATCH v2 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-04-28 11:34 ` Dmitry Baryshkov
2026-04-28 9:15 ` [PATCH v2 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-04-28 9:15 ` [PATCH v2 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-04-28 11:35 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI4U6SPMW5GG.34DH11UKWPUEX@bootlin.com \
--to=luca.ceresoli@bootlin$(echo .)com \
--cc=Hui.Pu@gehealthcare$(echo .)com \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=abhinav.kumar@linux$(echo .)dev \
--cc=airlied@gmail$(echo .)com \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=gye976@gmail$(echo .)com \
--cc=ian.ray@gehealthcare$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jesszhan0024@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=jstultz@google$(echo .)com \
--cc=kong.kongxinwei@hisilicon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lumag@kernel$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=marijn.suijten@somainline$(echo .)org \
--cc=michal.simek@amd$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=rfoss@kernel$(echo .)org \
--cc=robin.clark@oss$(echo .)qualcomm.com \
--cc=sean@poorly$(echo .)run \
--cc=simona@ffwll$(echo .)ch \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=tiantao6@hisilicon$(echo .)com \
--cc=tomi.valkeinen@ideasonboard$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox