From: "Luca Ceresoli" <luca.ceresoli@bootlin•com>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard•com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel•com>,
"Neil Armstrong" <neil.armstrong@linaro•org>,
"Robert Foss" <rfoss@kernel•org>,
"Jonas Karlman" <jonas@kwiboo•se>,
"Jernej Skrabec" <jernej.skrabec@gmail•com>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Rob Clark" <robin.clark@oss•qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel•org>,
"Abhinav Kumar" <abhinav.kumar@linux•dev>,
"Jessica Zhang" <jesszhan0024@gmail•com>,
"Sean Paul" <sean@poorly•run>,
"Marijn Suijten" <marijn.suijten@somainline•org>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"John Stultz" <jstultz@google•com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard•com>,
"Michal Simek" <michal.simek@amd•com>,
"Hui Pu" <Hui.Pu@gehealthcare•com>,
"Ian Ray" <ian.ray@gehealthcare•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
<dri-devel@lists•freedesktop.org>, <linux-kernel@vger•kernel.org>,
<linux-arm-msm@vger•kernel.org>,
<freedreno@lists•freedesktop.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v4 10/11] drm: zynqmp_dp: switch to of_drm_get_bridge_by_endpoint()
Date: Tue, 05 May 2026 16:05:36 +0200 [thread overview]
Message-ID: <DIASTWTYYQDQ.1R0JI8NB9I4KE@bootlin.com> (raw)
In-Reply-To: <20260504152418.GC1455860@killaraus.ideasonboard.com>
Hi Laurent,
On Mon May 4, 2026 at 5:24 PM CEST, Laurent Pinchart wrote:
[...]
>> @@ -2461,10 +2459,15 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
>> * Acquire the next bridge in the chain. Ignore errors caused by port@5
>> * not being connected for backward-compatibility with older DTs.
>> */
>> - ret = drm_of_find_panel_or_bridge(dp->dev->of_node, 5, 0, NULL,
>> - &dp->next_bridge);
>> - if (ret < 0 && ret != -ENODEV)
>> - goto err_reset;
>> + dp->bridge.next_bridge = of_drm_get_bridge_by_endpoint(dp->dev->of_node, 5, 0);
>> + if (IS_ERR(dp->bridge.next_bridge)) {
>> + if (PTR_ERR(dp->bridge.next_bridge) == -ENODEV) {
>> + dp->bridge.next_bridge = NULL;
>> + } else {
>> + ret = PTR_ERR(dp->bridge.next_bridge);
>> + goto err_reset;
>> + }
>
> I would find
>
> if (PTR_ERR(dp->bridge.next_bridge) != -ENODEV) {
> ret = PTR_ERR(dp->bridge.next_bridge);
> goto err_reset;
> }
>
> dp->bridge.next_bridge = NULL;
>
> easier to read. Up to you.
Makes sense, change queued up for v5.
Thanks for reviewing!
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-05-05 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:45 [PATCH v4 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR Luca Ceresoli
2026-05-04 13:53 ` Laurent Pinchart
2026-05-04 14:13 ` Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 14:55 ` Laurent Pinchart
2026-05-04 15:03 ` Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-04 15:22 ` Laurent Pinchart
2026-05-04 10:45 ` [PATCH v4 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-04 15:24 ` Laurent Pinchart
2026-05-05 14:05 ` Luca Ceresoli [this message]
2026-05-04 10:45 ` [PATCH v4 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 15:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIASTWTYYQDQ.1R0JI8NB9I4KE@bootlin.com \
--to=luca.ceresoli@bootlin$(echo .)com \
--cc=Hui.Pu@gehealthcare$(echo .)com \
--cc=abhinav.kumar@linux$(echo .)dev \
--cc=airlied@gmail$(echo .)com \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=ian.ray@gehealthcare$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jesszhan0024@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=jstultz@google$(echo .)com \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lumag@kernel$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=marijn.suijten@somainline$(echo .)org \
--cc=michal.simek@amd$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=rfoss@kernel$(echo .)org \
--cc=robin.clark@oss$(echo .)qualcomm.com \
--cc=sean@poorly$(echo .)run \
--cc=simona@ffwll$(echo .)ch \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=tomi.valkeinen@ideasonboard$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox