Subject: Re: [PATCH 5/6] firmware: samsung: acpm: Add TMU protocol support

From: "Alexey Klimov" <[email-masked]>
Date: Mon, 25 May 2026 00:02:55 +0100

On Thu May 21, 2026 at 3:49 PM BST, Tudor Ambarus wrote:
> Hi, Alexey,
>
> On 5/21/26 4:37 PM, Alexey Klimov wrote:
>> Peter, I agree we shouldn't bother about hypothetical SoCs. However,
>
> It's standard kernel philosophy to not add code that __might__ be useful
> later.

No idea what you mean by saying standard kernel philosophy but people
do add code that might be useful later. Some examples are:
-- ftrace subsystem;
-- commit eb2415854f3ba7d95c4f30d259f6f598ab604616
-- commit 78723fe309f189ee4010d5b7a55f6a14644a40c2
(if you so fancy about debug printk)

We can probably find more examples.

> Please consider adding that print when you submit support for
> e850.

Support for e850 was already sent:
https://lore.kernel.org/linux-samsung-soc/[email-masked]/

It doesn't matter now. Krzysztof already accepted ACPM TMU with error
conversion variant for gs101 only.
It will be nice to see ACPM that is more generic towards Exynos/Samsung
SoCs rather than gs.

BR,
Alexey.