From: "Alexey Klimov" <alexey.klimov@linaro•org>
To: "Alexander A. Klimov" <grandmaster@al2klimov•de>,
"Krzysztof Kozlowski" <krzk@kernel•org>,
"Sylwester Nawrocki" <s.nawrocki@samsung•com>,
"Chanwoo Choi" <cw00.choi@samsung•com>,
"Alim Akhtar" <alim.akhtar@samsung•com>,
"Michael Turquette" <mturquette@baylibre•com>,
"Stephen Boyd" <sboyd@kernel•org>,
"Brian Masney" <bmasney@redhat•com>,
"open list:SAMSUNG SOC CLOCK DRIVERS"
<linux-samsung-soc@vger•kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger•kernel.org>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists•infradead.org>,
"open list" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
Date: Thu, 28 May 2026 02:15:33 +0100 [thread overview]
Message-ID: <DITWUUN7L160.5VKMP4HONZ4@linaro.org> (raw)
In-Reply-To: <20260526061321.6123-1-grandmaster@al2klimov.de>
On Tue May 26, 2026 at 7:13 AM BST, Alexander A. Klimov wrote:
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
>
> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
Reviewed-by: Alexey Klimov <alexey.klimov@linaro•org>
> ---
> drivers/clk/samsung/clk-exynos5410.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
> index baa9988c7bb7..0cd9b0392cf5 100644
> --- a/drivers/clk/samsung/clk-exynos5410.c
> +++ b/drivers/clk/samsung/clk-exynos5410.c
> @@ -269,8 +269,12 @@ static void __init exynos5410_clk_init(struct device_node *np)
> {
> struct clk *xxti = of_clk_get(np, 0);
>
> - if (!IS_ERR(xxti) && clk_get_rate(xxti) == 24 * MHZ)
> - exynos5410_plls[epll].rate_table = exynos5410_pll2550x_24mhz_tbl;
> + if (!IS_ERR(xxti)) {
> + if (clk_get_rate(xxti) == 24 * MHZ)
> + exynos5410_plls[epll].rate_table =
> + exynos5410_pll2550x_24mhz_tbl;
> + clk_put(xxti);
> + }
>
> samsung_cmu_register_one(np, &cmu);
Best regards,
Alexey Klimov
next prev parent reply other threads:[~2026-05-28 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
2026-05-26 17:29 ` Brian Masney
2026-05-28 1:15 ` Alexey Klimov [this message]
2026-05-28 8:02 ` Peter Griffin
2026-05-30 16:26 ` Krzysztof Kozlowski
2026-05-31 9:27 ` Alexander A. Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DITWUUN7L160.5VKMP4HONZ4@linaro.org \
--to=alexey.klimov@linaro$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=bmasney@redhat$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=grandmaster@al2klimov$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=mturquette@baylibre$(echo .)com \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox