From: "Alexey Klimov" <alexey.klimov@linaro•org>
To: "Tudor Ambarus" <tudor.ambarus@linaro•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Daniel Lezcano" <daniel.lezcano@kernel•org>,
"Zhang Rui" <rui.zhang@intel•com>,
"Lukasz Luba" <lukasz.luba@arm•com>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Bartlomiej Zolnierkiewicz" <bzolnier@gmail•com>,
"Krzysztof Kozlowski" <krzk@kernel•org>,
"Kees Cook" <kees@kernel•org>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
"Peter Griffin" <peter.griffin@linaro•org>,
"André Draszik" <andre.draszik@linaro•org>,
"Alim Akhtar" <alim.akhtar@samsung•com>
Cc: <jyescas@google•com>, <linux-kernel@vger•kernel.org>,
<linux-samsung-soc@vger•kernel.org>, <linux-pm@vger•kernel.org>,
<devicetree@vger•kernel.org>, <linux-hardening@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss•qualcomm.com>
Subject: Re: [PATCH v7 2/5] thermal: samsung: Add Exynos ACPM TMU driver GS101
Date: Tue, 02 Jun 2026 20:49:29 +0100 [thread overview]
Message-ID: <DIYTOGU8I2DV.1GKZ59F7AJWTE@linaro.org> (raw)
In-Reply-To: <20260602-acpm-tmu-v7-2-8047dd54b0e9@linaro.org>
On Tue Jun 2, 2026 at 6:00 PM BST, Tudor Ambarus wrote:
> Add driver for the Thermal Management Unit (TMU) managed via the Alive
> Clock and Power Manager (ACPM), found on Samsung Exynos SoCs such as
> Google GS101 (and Exynos850, autov920, etc.).
>
> The TMU on utilizes a hybrid management model shared between the
> Application Processor (AP) and the ACPM firmware. The driver maintains
> direct memory-mapped access to the TMU interrupt pending registers to
> identify thermal events, while delegating functional tasks - such as
> sensor initialization, threshold configuration, and temperature
> acquisition - to the ACPM firmware via the ACPM IPC protocol.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro•org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
> ---
> drivers/thermal/samsung/Kconfig | 19 ++
> drivers/thermal/samsung/Makefile | 2 +
> drivers/thermal/samsung/acpm-tmu.c | 618 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 639 insertions(+)
>
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index f4eff5a41a84..383ae3f56cbb 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -9,3 +9,22 @@ config EXYNOS_THERMAL
> the TMU, reports temperature and handles cooling action if defined.
> This driver uses the Exynos core thermal APIs and TMU configuration
> data from the supported SoCs.
> +
> +config EXYNOS_ACPM_THERMAL
> + tristate "Exynos ACPM thermal management unit driver"
> + depends on THERMAL_OF
> + depends on HAS_IOMEM
> + depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL)
> + default ARCH_EXYNOS
> + help
> + Support for the Thermal Management Unit (TMU) on Samsung Exynos SoCs
> + (such as Google GS101 and Exynos850).
This driver doesn't support Exynos850. There is no initialisation sequence
and etc, moreover the next section is also not entirely correct for Exynos850.
Not sure why it is mentioned here in such way.
(Not even mentioning that ACPM TMU part is not aligned for Exynos850)
> + The TMU on these platforms is managed through a hybrid architecture.
> + This driver handles direct register access for thermal interrupt status
> + monitoring and communicates with the Alive Clock and Power Manager
> + (ACPM) firmware via the ACPM IPC protocol for functional sensor control
> + and configuration.
> + Select this if you want to monitor device temperature and enable
> + thermal mitigation on Samsung Exynos ACPM based devices.
[..]
BR,
Alexey
next prev parent reply other threads:[~2026-06-02 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 17:00 [PATCH v7 0/5] thermal: samsung: Add support for Google GS101 TMU Tudor Ambarus
2026-06-02 17:00 ` [PATCH v7 1/5] dt-bindings: thermal: Add " Tudor Ambarus
2026-06-02 17:00 ` [PATCH v7 2/5] thermal: samsung: Add Exynos ACPM TMU driver GS101 Tudor Ambarus
2026-06-02 19:49 ` Alexey Klimov [this message]
2026-06-03 9:26 ` Tudor Ambarus
2026-06-03 10:38 ` Alexey Klimov
2026-06-03 12:30 ` Tudor Ambarus
2026-06-02 17:00 ` [PATCH v7 3/5] MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver Tudor Ambarus
2026-06-02 17:00 ` [PATCH v7 4/5] arm64: dts: exynos: gs101: Add thermal management unit Tudor Ambarus
2026-06-02 17:00 ` [PATCH v7 5/5] arm64: defconfig: enable Exynos ACPM thermal support Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIYTOGU8I2DV.1GKZ59F7AJWTE@linaro.org \
--to=alexey.klimov@linaro$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andre.draszik@linaro$(echo .)org \
--cc=bzolnier@gmail$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=daniel.lezcano@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gustavoars@kernel$(echo .)org \
--cc=jyescas@google$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=krzysztof.kozlowski@oss$(echo .)qualcomm.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=lukasz.luba@arm$(echo .)com \
--cc=peter.griffin@linaro$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
--cc=tudor.ambarus@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox