From: "Rosen Penev" <rosenp@gmail•com>
To: "Michal Simek" <michal.simek@amd•com>, "Rosen Penev" <rosenp@gmail•com>
Cc: <linux-kernel@vger•kernel.org>, "Arnd Bergmann" <arnd@arndb•de>,
<chleroy@kernel•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH] char: xilinx_hwicap: replace in_be32/out_be32 with ioread32be/iowrite32be
Date: Thu, 04 Jun 2026 00:13:15 -0700 [thread overview]
Message-ID: <DJ02UJDHW927.1ZCLQQ77E0I95@gmail.com> (raw)
In-Reply-To: <e331f8d0-11e7-40c1-b4f5-76a591e93bd9@amd.com>
On Wed Jun 3, 2026 at 11:30 PM PDT, Michal Simek wrote:
>
>
> On 6/3/26 21:52, Rosen Penev wrote:
>> On Mon, Jun 1, 2026 at 11:22 PM Michal Simek <michal.simek@amd•com> wrote:
>>>
>>>
>>>
>>> On 6/2/26 05:57, Rosen Penev wrote:
>>>> Mechanical conversion of the ppc4xx-specific accessors to the generic
>>>> portable helpers.
>>>>
>>>> As a result, COMPILE_TEST is added for extra compile coverage.
>>>>
>>>> Assisted-by: opencode:big-pickle
>>>> Signed-off-by: Rosen Penev <rosenp@gmail•com>
>>>> ---
>>>> drivers/char/Kconfig | 2 +-
>>>> drivers/char/xilinx_hwicap/buffer_icap.c | 16 +++++------
>>>> drivers/char/xilinx_hwicap/fifo_icap.c | 34 +++++++++++-------------
>>>> 3 files changed, 24 insertions(+), 28 deletions(-)
>>>
>>> I don't really mind about this because I think that we can also remove the whole
>>> driver.
>> I looked into this. The problem here is that there are actual users
>>
>> arch/microblaze/boot/dts/system.dts
>>
>> and
>>
>> arch/mips/boot/dts/xilfpga/nexys4ddr.dts
>
>
> I can't see users of it.
Hrm looks like I just grepped xlns,xps and found system.dts. You're
right.
>
> on v7.1-rc1
> $ git grep opb-hwicap
> Documentation/devicetree/bindings/xilinx.txt:126:
> "xlnx,opb-hwicap-1.00.b".
> drivers/char/xilinx_hwicap/xilinx_hwicap.c:733: { .compatible =
> "xlnx,opb-hwicap-1.00.b", .data = &buffer_icap_config},
> $ git grep xps-hwicap
> Documentation/devicetree/bindings/xilinx.txt:125: - compatible :
> should contain "xlnx,xps-hwicap-1.00.a" or
> drivers/char/xilinx_hwicap/xilinx_hwicap.c:734: { .compatible =
> "xlnx,xps-hwicap-1.00.a", .data = &fifo_icap_config},
>
> Thanks,
> Michal
prev parent reply other threads:[~2026-06-04 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 3:57 [PATCH] char: xilinx_hwicap: replace in_be32/out_be32 with ioread32be/iowrite32be Rosen Penev
2026-06-02 6:22 ` Michal Simek
2026-06-03 19:52 ` Rosen Penev
2026-06-04 6:30 ` Michal Simek
2026-06-04 7:13 ` Rosen Penev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ02UJDHW927.1ZCLQQ77E0I95@gmail.com \
--to=rosenp@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=chleroy@kernel$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michal.simek@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox