From: Sergey Senozhatsky <senozhatsky@chromium•org>
To: Marc Zyngier <maz@kernel•org>
Cc: Sergey Senozhatsky <senozhatsky@chromium•org>,
Paolo Bonzini <pbonzini@redhat•com>,
Sean Christopherson <seanjc@google•com>,
Vitaly Kuznetsov <vkuznets@redhat•com>,
Jim Mattson <jmattson@google•com>,
Huacai Chen <chenhuacai@kernel•org>,
Paul Mackerras <paulus@ozlabs•org>,
Christian Borntraeger <borntraeger@de•ibm.com>,
Suleiman Souhlal <suleiman@google•com>,
x86@kernel•org, linux-arm-kernel@lists•infradead.org,
kvmarm@lists•cs.columbia.edu, linux-kernel@vger•kernel.org,
linux-mips@vger•kernel.org, kvm@vger•kernel.org,
kvm-ppc@vger•kernel.org, linux-s390@vger•kernel.org
Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier
Date: Sat, 5 Jun 2021 09:58:10 +0900 [thread overview]
Message-ID: <YLrMIugtkxePl/UZ@google.com> (raw)
In-Reply-To: <87tumeymih.wl-maz@kernel.org>
On (21/06/04 11:03), Marc Zyngier wrote:
[..]
> > Well on the other hand PM-callbacks are harmless on those archs, they
> > won't overload the __weak function.
>
> I don't care much for the callbacks. But struct kvm is bloated enough,
> and I'd be happy not to have this structure embedded in it if I can
> avoid it.
Got it.
> > > How about passing the state to the notifier callback? I'd expect it to
> > > be useful to do something on resume too.
> >
> > For different states we can have different kvm_arch functions instead.
> > kvm_arch_pm_notifier() can be renamed to kvm_arch_suspend_notifier(),
> > so that we don't need to have `switch (state)` in every arch-code. Then
> > for resume/post resume states we can have kvm_arch_resume_notifier()
> > arch functions.
>
> I'd rather we keep an arch API that is similar to the one the rest of
> the kernel has, instead of a flurry of small helpers that need to grow
> each time someone adds a new PM state. A switch() in the arch-specific
> implementation is absolutely fine.
OK.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-05 1:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 16:43 [RFC][PATCH] kvm: add suspend pm-notifier Sergey Senozhatsky
2021-06-03 17:27 ` Peter Zijlstra
2021-06-04 0:39 ` Sergey Senozhatsky
2021-06-04 7:17 ` Paolo Bonzini
2021-06-04 7:21 ` Vitaly Kuznetsov
2021-06-04 7:24 ` Paolo Bonzini
2021-06-04 9:22 ` Sergey Senozhatsky
2021-06-04 8:46 ` Marc Zyngier
2021-06-04 9:20 ` Sergey Senozhatsky
2021-06-04 10:03 ` Marc Zyngier
2021-06-05 0:58 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLrMIugtkxePl/UZ@google.com \
--to=senozhatsky@chromium$(echo .)org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=jmattson@google$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=paulus@ozlabs$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=suleiman@google$(echo .)com \
--cc=vkuznets@redhat$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox