From: Rob Herring <robh@kernel•org>
To: haibo.chen@nxp•com
Cc: adrian.hunter@intel•com, ulf.hansson@linaro•org,
shawnguo@kernel•org, s.hauer@pengutronix•de,
kernel@pengutronix•de, festevam@gmail•com,
linux-mmc@vger•kernel.org, linux-imx@nxp•com,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 3/6] dt-bindings: mmc: fsl-imx-esdhc: add fsl,broken-auto-tuning binding
Date: Wed, 18 Aug 2021 13:48:52 -0500 [thread overview]
Message-ID: <YR1WFGUGS3pERnOD@robh.at.kernel.org> (raw)
In-Reply-To: <1629285415-7495-3-git-send-email-haibo.chen@nxp.com>
On Wed, Aug 18, 2021 at 07:16:52PM +0800, haibo.chen@nxp•com wrote:
> From: Haibo Chen <haibo.chen@nxp•com>
>
> Add a new fsl,broken-auto-tuning binding for sdio devices. When sdio
> device support sdio interrupt, need to use this property to disable
> auto-tuning. Auto-tuning circuit is conflict with sdio interrupt.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp•com>
> ---
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index b5baf439fbac..d7c8e5880473 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -93,6 +93,15 @@ properties:
> tuning step can't find the proper delay window within limited tuning retries.
> default: 0
>
> + fsl,broken-auto-tuning:
> + description: |
> + Recommend for SDIO cards that enables SDIO interrupt for SDR104 and SDR50 mode.
> + SDIO interrupt uses DAT[1] to signal the card's interrupt. Auto-tuning circuit
> + will detect this interrupt on DAT[1] when in 4Bit bus mode, and take it just
> + as normal data, wrongly adjust the delay cell. This property is used to disable
> + the auto-tuning function.
> + type: boolean
Seems like something that could be broken on a variety of hosts and
should be common?
If auto tuning is broken, shouldn't that speed be disabled?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-18 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 11:16 [PATCH v2 1/6] mmc: sdhci-esdhc-imx: remove redundant code for manual tuning haibo.chen
2021-08-18 11:16 ` [PATCH v2 2/6] mmc: sdhci-eadhc-imx: select the correct mode for auto tuning haibo.chen
2021-08-18 11:16 ` [PATCH v2 3/6] dt-bindings: mmc: fsl-imx-esdhc: add fsl, broken-auto-tuning binding haibo.chen
2021-08-18 18:48 ` Rob Herring [this message]
2021-08-19 14:11 ` Lucas Stach
2021-08-18 11:16 ` [PATCH v2 4/6] mmc: host: sdhci-esdhc-imx.c: disable auto-tuning when necessary haibo.chen
2022-12-05 14:59 ` Kevin Groeneveld
2022-12-09 8:43 ` Bough Chen
2021-08-18 11:16 ` [PATCH v2 5/6] arm64: dts: imx8mm-evk: add sdio wifi support haibo.chen
2021-08-18 11:16 ` [PATCH v2 6/6] arm64: dts: imx8mn-evk: " haibo.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR1WFGUGS3pERnOD@robh.at.kernel.org \
--to=robh@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=haibo.chen@nxp$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=ulf.hansson@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox