From: Rob Herring <robh@kernel•org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: devicetree@vger•kernel.org, Daniel Vetter <daniel@ffwll•ch>,
David Airlie <airlied@linux•ie>, Shawn Guo <shawnguo@kernel•org>,
dri-devel <dri-devel@lists•freedesktop.org>,
NXP Linux Team <linux-imx@nxp•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Philipp Zabel <p.zabel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-arm-kernel <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs
Date: Tue, 1 Feb 2022 11:35:07 -0600 [thread overview]
Message-ID: <YflvS007gL5mLa9k@robh.at.kernel.org> (raw)
In-Reply-To: <20220128175829.vjm66rs7eu7pk2my@pengutronix.de>
On Fri, Jan 28, 2022 at 06:58:29PM +0100, Uwe Kleine-König wrote:
> Hello Rob,
>
> On Fri, Jan 28, 2022 at 07:04:10AM -0600, Rob Herring wrote:
> > On Fri, Jan 28, 2022 at 4:59 AM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix•de> wrote:
> > >
> > > From: Marian Cichy <m.cichy@pengutronix•de>
> > >
> > > This files documents the device tree for the new imx21-lcdc DRM driver.
> >
> > No, bindings document h/w and the h/w has not changed. We already have
> > a binding for the LCDC.
>
> Just to be sure we're talking about the same thing: You're refering to
> Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt, right?
Looks right...
> I'm unsure what to do now. Should the two different bindings just be
> described in the same file? Should I stick to fsl,imx21-fb even for the
> new binding? (The hardware unit is named LCDC, so the name chosen here
> is the better one.) Please advise.
Yes, the name is unfortunate, but it should be 1 binding, 1 file, and
unchanged (unless you want to add new optional properties).
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-01 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 10:58 [PATCH 0/2] drm/imx/lcdc: drm driver for imx21/25/27 Uwe Kleine-König
2022-01-28 10:58 ` [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs Uwe Kleine-König
2022-01-28 13:04 ` Rob Herring
2022-01-28 17:58 ` Uwe Kleine-König
2022-02-01 17:35 ` Rob Herring [this message]
2022-02-10 17:54 ` Lucas Stach
2022-02-21 13:55 ` Uwe Kleine-König
2022-03-22 17:43 ` Uwe Kleine-König
2022-03-22 18:56 ` Rob Herring
2022-01-28 10:58 ` [PATCH 2/2] drm/imx/lcdc: Implement DRM driver for imx21 Uwe Kleine-König
2022-01-28 21:03 ` kernel test robot
2022-01-28 22:25 ` kernel test robot
2022-01-29 10:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YflvS007gL5mLa9k@robh.at.kernel.org \
--to=robh@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox