From: Florian Fainelli <f.fainelli@gmail•com>
To: Stefan Wahren <wahrenst@gmx•net>, Chen-Yu Tsai <wens@kernel•org>,
Markus Mayer <mmayer@broadcom•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Zhang Rui <rui.zhang@intel•com>,
Eduardo Valentin <edubezval@gmail•com>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
Amit Kucheria <amit.kucheria@verdurent•com>
Cc: Chen-Yu Tsai <wens@csie•org>,
bcm-kernel-feedback-list@broadcom•com,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-pm@vger•kernel.org
Subject: Re: [PATCH] thermal: brcmstb: enable hwmon
Date: Thu, 31 Oct 2019 20:01:51 -0700 [thread overview]
Message-ID: <a3345dbd-19c6-ab9d-a19c-b8ee0a703c17@gmail.com> (raw)
In-Reply-To: <91017889-2ae7-d467-eed3-6d3b2bb130b9@gmx.net>
On 10/31/2019 6:08 AM, Stefan Wahren wrote:
> Hi Chen-Yu,
>
> Am 30.10.19 um 17:38 schrieb Chen-Yu Tsai:
>> From: Chen-Yu Tsai <wens@csie•org>
>>
>> By defaul of-based thermal driver do not have hwmon entries registered.
>>
>> Do this explicitly so users can use standard hwmon interfaces and tools
>> to read the temperature.
>>
>> This is based on similar changes for bcm2835_thermal in commit
>> d56c19d07e0b ("thermal: bcm2835: enable hwmon explicitly").
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie•org>
>> ---
>>
>> This patch was only compile tested. A similar patch [1] was submitted to
>> the downstream kernel, which I did build and actually run on a Raspberry
>> Pi 4.
>
> just a note: from my understanding [2] the brcmstb_thermal isn't the
> right driver for BCM2711. Please consider the current downstream
> solution for BCM2711 support as a quick hack to avoid writing a new
> thermal driver. But must confess that i didn't test Florian's recent
> changes yet.
The brcmstb_thermal driver is for chips with an AVS_TMON whereas the
2711 does not have it AFAICT, even if the registers are there, the
hardware is not present (or so have I been told).
The AVS_RO register you are being pointed out may work, although the
data is over 10 bits (not 11) and the valid bit is 10 (not 11). It looks
like you may have to check bit 16 as well for a measurement being done
or not.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-01 3:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:38 [PATCH] thermal: brcmstb: enable hwmon Chen-Yu Tsai
2019-10-30 16:57 ` Florian Fainelli
2019-10-30 17:15 ` Florian Fainelli
2019-10-31 13:08 ` Stefan Wahren
2019-11-01 3:01 ` Florian Fainelli [this message]
2019-11-01 3:04 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3345dbd-19c6-ab9d-a19c-b8ee0a703c17@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=edubezval@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mmayer@broadcom$(echo .)com \
--cc=rui.zhang@intel$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
--cc=wens@csie$(echo .)org \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox