From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
"David S. Miller" <davem@davemloft•net>,
Emil Renner Berthing <kernel@esmil•dk>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Jerome Brunet <jbrunet@baylibre•com>,
Keguang Zhang <keguang.zhang@gmail•com>,
Kevin Hilman <khilman@baylibre•com>,
linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org, linux-mips@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Minda Chen <minda.chen@starfivetech•com>,
Neil Armstrong <neil.armstrong@linaro•org>,
netdev@vger•kernel.org,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail•toshiba>,
Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH net-next 16/16] net: stmmac: visconti: use stmmac_get_phy_intf_sel()
Date: Sat, 8 Nov 2025 07:58:19 +0000 [thread overview]
Message-ID: <aQ74G_WqoAusC2wd@shell.armlinux.org.uk> (raw)
In-Reply-To: <14f80863-5766-437a-8e38-8991a1a725f9@bootlin.com>
On Fri, Nov 07, 2025 at 07:23:26PM +0100, Maxime Chevallier wrote:
> Hi Russell,
>
> On 07/11/2025 15:29, Russell King (Oracle) wrote:
> > - switch (plat_dat->phy_interface) {
> > - case PHY_INTERFACE_MODE_RGMII:
> > - case PHY_INTERFACE_MODE_RGMII_ID:
> > - case PHY_INTERFACE_MODE_RGMII_RXID:
> > - case PHY_INTERFACE_MODE_RGMII_TXID:
> > - phy_intf_sel = ETHER_CONFIG_INTF_RGMII;
> > - break;
> > - case PHY_INTERFACE_MODE_MII:
> > - phy_intf_sel = ETHER_CONFIG_INTF_MII;
> > - break;
> > - case PHY_INTERFACE_MODE_RMII:
> > - phy_intf_sel = ETHER_CONFIG_INTF_RMII;
> > - break;
> > - default:
> > + int phy_intf_sel;
> > +
> > + phy_intf_sel = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
> > + if (phy_intf_sel != PHY_INTF_SEL_GMII_MII &&
> > + phy_intf_sel != PHY_INTF_SEL_RGMII &&
> > + phy_intf_sel != PHY_INTF_SEL_RMII) {
> > dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n", plat_dat->phy_interface);
> > return -EOPNOTSUPP;
> > }
>
> Probably not too big of a deal, but don't we now incorrectly accept the
> "gmii" mode ?
We will accept GMII mode, but (a) does that matter, and (b) shouldn't
the DT binding be checking the phy-mode (we have some bindings that do.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-08 7:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 14:27 [PATCH net-next 00/16] net: stmmac: convert glue drivers to use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 01/16] net: stmmac: loongson1: use PHY_INTF_SEL_x Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 02/16] net: stmmac: loongson1: use PHY_INTF_SEL_x directly Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 03/16] net: stmmac: loongson1: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 04/16] net: stmmac: mediatek: use PHY_INTF_SEL_xxx Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 05/16] net: stmmac: mediatek: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 06/16] net: stmmac: mediatek: simplify set_interface() methods Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 07/16] net: stmmac: meson8b: use PHY_INTF_SEL_xxx Russell King (Oracle)
2025-11-08 12:30 ` Martin Blumenstingl
2025-11-07 14:28 ` [PATCH net-next 08/16] net: stmmac: meson8b: use phy_intf_sel directly Russell King (Oracle)
2025-11-08 12:30 ` Martin Blumenstingl
2025-11-07 14:28 ` [PATCH net-next 09/16] net: stmmac: meson8b: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-08 12:31 ` Martin Blumenstingl
2025-11-07 14:28 ` [PATCH net-next 10/16] net: stmmac: starfive: use PHY_INTF_SEL_xxx to select PHY interface Russell King (Oracle)
2025-11-07 14:28 ` [PATCH net-next 11/16] net: stmmac: starfive: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 16:00 ` Emil Renner Berthing
2025-11-07 16:08 ` Russell King (Oracle)
2025-11-07 14:29 ` [PATCH net-next 12/16] net: stmmac: stm32: use PHY_INTF_SEL_x to select PHY interface Russell King (Oracle)
2025-11-07 14:29 ` [PATCH net-next 13/16] net: stmmac: stm32: use PHY_INTF_SEL_x directly Russell King (Oracle)
2025-11-07 14:29 ` [PATCH net-next 14/16] net: stmmac: stm32: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 14:29 ` [PATCH net-next 15/16] net: stmmac: visconti: use PHY_INTF_SEL_x to select PHY interface Russell King (Oracle)
2025-11-07 14:29 ` [PATCH net-next 16/16] net: stmmac: visconti: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-07 18:23 ` Maxime Chevallier
2025-11-08 7:58 ` Russell King (Oracle) [this message]
2025-11-09 16:38 ` Maxime Chevallier
2025-11-11 8:08 ` [PATCH net-next 00/13] net: stmmac: convert glue drivers to " Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ74G_WqoAusC2wd@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=keguang.zhang@gmail$(echo .)com \
--cc=kernel@esmil$(echo .)dk \
--cc=khilman@baylibre$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=minda.chen@starfivetech$(echo .)com \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nobuhiro.iwamatsu.x90@mail$(echo .)toshiba \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox